From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751150AbdEaI5f (ORCPT ); Wed, 31 May 2017 04:57:35 -0400 Received: from mx4.wp.pl ([212.77.101.11]:12534 "EHLO mx4.wp.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750869AbdEaI5e (ORCPT ); Wed, 31 May 2017 04:57:34 -0400 Date: Wed, 31 May 2017 01:57:21 -0700 From: Jakub Kicinski To: Arnd Bergmann Cc: Simon Horman , "David S. Miller" , oss-drivers@netronome.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] nfp: add MAY_USE_DEVLINK dependency Message-ID: <20170531015721.7a6d230e@cakuba.lan> In-Reply-To: <20170531081700.1948289-1-arnd@arndb.de> References: <20170531081700.1948289-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-WP-MailID: 3d038e2fc4eecc8c3336f26665cc31b8 X-WP-AV: skaner antywirusowy Poczty Wirtualnej Polski X-WP-SPAM: NO 000000A [cRM0] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 31 May 2017 10:16:50 +0200, Arnd Bergmann wrote: > When devlink is configured as a loadable module, a built-in nfp driver > causes a link error: > > drivers/net/built-in.o: In function `nfp_devlink_port_register': > (.text+0xb8b05): undefined reference to `devlink_port_type_eth_set' > drivers/net/built-in.o: In function `nfp_devlink_port_register': > (.text+0xb8b16): undefined reference to `devlink_port_split_set' > > This adds a special Kconfig dependency on CONFIG_MAY_USE_DEVLINK > to avoid that combination and force nfp to be a module when NET_DEVLINK=m. Thanks, this should be fixed in net-next already by commit d935bc84c940 ("nfp: add MAY_USE_DEVLINK dependency"). Same subject/commit title as yours :)