From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751195AbdEaGfm (ORCPT ); Wed, 31 May 2017 02:35:42 -0400 Received: from mga03.intel.com ([134.134.136.65]:59342 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750916AbdEaGfl (ORCPT ); Wed, 31 May 2017 02:35:41 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,422,1491289200"; d="asc'?scan'208";a="1176390372" Date: Wed, 31 May 2017 14:30:16 +0800 From: Zhenyu Wang To: "Chen, Xiaoguang" Cc: "Tian, Kevin" , "intel-gfx@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "chris@chris-wilson.co.uk" , "alex.williamson@redhat.com" , "kraxel@redhat.com" , "Niu, Bing" , "intel-gvt-dev@lists.freedesktop.org" , "Wang, Zhi A" , "Lv, Zhiyuan" Subject: Re: [PATCH v6 2/6] drm/i915/gvt: OpRegion support for GVT-g Message-ID: <20170531063015.7a7k77kygi6eoftp@zhen-hp.sh.intel.com> Reply-To: Zhenyu Wang References: <1495874332-2851-1-git-send-email-xiaoguang.chen@intel.com> <1495874332-2851-3-git-send-email-xiaoguang.chen@intel.com> <20170531044721.wpazhx267txbmvwb@zhen-hp.sh.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="zqpn7nulaxmjqcvs" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170306 (1.8.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --zqpn7nulaxmjqcvs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2017.05.31 06:22:28 +0000, Chen, Xiaoguang wrote: > >> @@ -467,6 +555,15 @@ static int intel_vgpu_create(struct kobject *kobj, > >struct mdev_device *mdev) > >> vgpu->vdev.mdev =3D mdev; > >> mdev_set_drvdata(mdev, vgpu); > >> > >> + ret =3D intel_vgpu_reg_init_opregion(vgpu); > >> + if (ret) { > >> + gvt_vgpu_err("create OpRegion failed\n"); > >> + goto out; > >> + } > > > >Still need to handle error path for created vgpu. > Just checked the code, if initialize the opregion failed we should first = release vfio/mdev releated work(maybe call intel_vgpu_release function) an= d then destroy the vgpu. Will update in the next version. >=20 Better to init opregion inside of create vgpu and do proper error handling there too. --=20 Open Source Technology Center, Intel ltd. $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827 --zqpn7nulaxmjqcvs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQTXuabgHDW6LPt9CICxBBozTXgYJwUCWS5i9wAKCRCxBBozTXgY J3P6AKCFG2EJ/4RMcj2dv/Dm2PZ6+3XmiACeLaS0tFiIaxR31icScNHQHvtPlII= =KY6o -----END PGP SIGNATURE----- --zqpn7nulaxmjqcvs--