From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751187AbdEaGeX (ORCPT <rfc822;w@1wt.eu>);
        Wed, 31 May 2017 02:34:23 -0400
Received: from mail-pf0-f196.google.com ([209.85.192.196]:33085 "EHLO
        mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751145AbdEaGeN (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 31 May 2017 02:34:13 -0400
Date: Wed, 31 May 2017 14:34:16 +0800
From: Dong Aisheng <dongas86@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Dong Aisheng <aisheng.dong@nxp.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Thomas Gleixner <tglx@linutronix.de>, Shawn Guo <shawnguo@kernel.org>,
        ping.bai@nxp.com, anson.huang@nxp.com,
        Sascha Hauer <kernel@pengutronix.de>
Subject: Re: [PATCH 2/2] timer: imx-tpm: add imx tpm timer support
Message-ID: <20170531063416.GA16812@b29396-OptiPlex-7040>
References: <1494660575-30465-1-git-send-email-aisheng.dong@nxp.com>
 <1494660575-30465-2-git-send-email-aisheng.dong@nxp.com>
 <CAK8P3a1JEzZFn4FXi2tb2jOFtV-3MRD-7O3gPBiZDM4qc3BTnA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAK8P3a1JEzZFn4FXi2tb2jOFtV-3MRD-7O3gPBiZDM4qc3BTnA@mail.gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Arnd,

On Thu, May 25, 2017 at 11:02:22PM +0200, Arnd Bergmann wrote:
> On Sat, May 13, 2017 at 9:29 AM, Dong Aisheng <aisheng.dong@nxp.com> wrote:
> 
> > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> > index 3356ab8..03dfd6a 100644
> > --- a/drivers/clocksource/Kconfig
> > +++ b/drivers/clocksource/Kconfig
> > @@ -590,6 +590,11 @@ config CLKSRC_IMX_GPT
> >         depends on ARM && CLKDEV_LOOKUP
> >         select CLKSRC_MMIO
> >
> > +config CLKSRC_IMX_TPM
> > +       bool "Clocksource using i.MX TPM" if COMPILE_TEST
> > +       depends on ARM && CLKDEV_LOOKUP && GENERIC_CLOCKEVENTS
> > +       select CLKSRC_MMIO
> > +
> 
> This needs a help text
> 

Got it

> 
> > +static inline void tpm_timer_disable(void)
> > +{
> > +       unsigned int val;
> > +
> > +       /* channel disable */
> > +       val = __raw_readl(timer_base + TPM_C0SC);
> > +       val &= ~(TPM_C0SC_MODE_MASK | TPM_C0SC_CHIE);
> > +       __raw_writel(val, timer_base + TPM_C0SC);
> > +}
> 
> __raw_readl/__raw_writel is broken on big-endian kernels, please
> use readl/writel instead.
> 

That's true.

Thanks for the kind reminder.

Regards
Dong Aisheng

>         Arnd