From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751134AbdEaGvd (ORCPT ); Wed, 31 May 2017 02:51:33 -0400 Received: from mx2.suse.de ([195.135.220.15]:51610 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751105AbdEaGvc (ORCPT ); Wed, 31 May 2017 02:51:32 -0400 Date: Wed, 31 May 2017 08:51:28 +0200 From: Michal Hocko To: kernel test robot Cc: Vinnie Magro , David Sterba , Omar Sandoval , LKML , Stephen Rothwell , lkp@01.org Subject: Re: [lkp-robot] [btrfs] beeeccca9b: WARNING:at_mm/util.c:#kvmalloc_node Message-ID: <20170531065128.GB3853@dhcp22.suse.cz> References: <20170531063033.GC1795@yexl-desktop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170531063033.GC1795@yexl-desktop> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 31-05-17 14:30:33, kernel test robot wrote: > > FYI, we noticed the following commit: > > commit: beeeccca9bebcec386cc31c250cff8a06cf27034 ("btrfs: Use kvzalloc instead of kzalloc/vmalloc in alloc_bitmap") > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master I have intentionally skipped alloc_bitmap because it relies on GFP_NOFS. This doesn't work properly when falling back to vmalloc and that is what the warning reported here says. I believe the right approach is to check whether the GFP_NOFS is _really_ needed and document why if yes. Otherwise drop the NOFS part in one patch with the explanation and convert it to kvmalloc in a separate patch. -- Michal Hocko SUSE Labs