From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751182AbdEaIFg (ORCPT ); Wed, 31 May 2017 04:05:36 -0400 Received: from mga03.intel.com ([134.134.136.65]:17458 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751149AbdEaIFd (ORCPT ); Wed, 31 May 2017 04:05:33 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,422,1491289200"; d="asc'?scan'208";a="1136476934" Date: Wed, 31 May 2017 15:59:56 +0800 From: Zhenyu Wang To: Nick Desaulniers Cc: Zhi Wang , Daniel Vetter , Jani Nikula , David Airlie , intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/i915/gvt: remove redundant -Wall Message-ID: <20170531075956.nlowmfqb7h3hvtfj@zhen-hp.sh.intel.com> Reply-To: Zhenyu Wang References: <20170521071527.17799-1-nick.desaulniers@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="mfs5ohhdzdif62th" Content-Disposition: inline In-Reply-To: <20170521071527.17799-1-nick.desaulniers@gmail.com> User-Agent: NeoMutt/20170306 (1.8.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --mfs5ohhdzdif62th Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2017.05.21 00:15:27 -0700, Nick Desaulniers wrote: > This flag is already set in the top level Makefile of the kernel. >=20 > Also, by having set CONFIG_DRM_I915_GVT, thereby appending -Wall to > ccflags, you undo all the -Wno-* cflags previously set in the Make > variable KBUILD_CFLAGS. >=20 > For example: >=20 > cc foo.c -Wall -Wno-format -Wall >=20 > resets -Wformat. >=20 > Signed-off-by: Nick Desaulniers > --- > I verified that -Wall was redundant by compiling with V=3D1: > make V=3D1 -j4 drivers/gpu/drm/i915/i915_gem_request.o >=20 > drivers/gpu/drm/i915/gvt/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/i915/gvt/Makefile b/drivers/gpu/drm/i915/gvt= /Makefile > index b123c20e2097..f5486cb94818 100644 > --- a/drivers/gpu/drm/i915/gvt/Makefile > +++ b/drivers/gpu/drm/i915/gvt/Makefile > @@ -3,6 +3,6 @@ GVT_SOURCE :=3D gvt.o aperture_gm.o handlers.o vgpu.o tra= ce_points.o firmware.o \ > interrupt.o gtt.o cfg_space.o opregion.o mmio.o display.o edid.o \ > execlist.o scheduler.o sched_policy.o render.o cmd_parser.o > =20 > -ccflags-y +=3D -I$(src) -I$(src)/$(GVT_DIR) -Wall > +ccflags-y +=3D -I$(src) -I$(src)/$(GVT_DIR) > i915-y +=3D $(addprefix $(GVT_DIR)/, $(GVT_SOURCE)) > obj-$(CONFIG_DRM_I915_GVT_KVMGT) +=3D $(GVT_DIR)/kvmgt.o > --=20 Pushed, thanks! --=20 Open Source Technology Center, Intel ltd. $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827 --mfs5ohhdzdif62th Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iFwEARECAB0WIQTXuabgHDW6LPt9CICxBBozTXgYJwUCWS53/AAKCRCxBBozTXgY J6e2AJ4jCO57JXUJePHdJbiGtWtpaXSdPgCY+fJJThSVEMieBfvmsaPwFldzGQ== =fkFh -----END PGP SIGNATURE----- --mfs5ohhdzdif62th--