From: Jiri Slaby <jslaby@suse.cz>
To: mingo@redhat.com
Cc: tglx@linutronix.de, hpa@zytor.com, x86@kernel.org,
linux-kernel@vger.kernel.org, Jiri Slaby <jslaby@suse.cz>
Subject: [PATCH 5/5] x86: entry, use ENTRY instead of ALIGN+GLOBAL for stub32_clone
Date: Wed, 31 May 2017 10:12:43 +0200 [thread overview]
Message-ID: <20170531081243.5709-5-jslaby@suse.cz> (raw)
In-Reply-To: <20170531081243.5709-1-jslaby@suse.cz>
ALIGN+GLOBAL is effectively what ENTRY does, so use ENTRY which is
dedicated for global functions.
Note that this is a C-like leaf function -- it has a correct stack
frame, switches one argument and continues by jumping into C. And since
each ENTRY should be balanced by some END*, we add a corresponding
ENDPROC to stub32_clone too.
Besides that, x86's custom GLOBAL macro is going to die very soon.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: <x86@kernel.org>
---
arch/x86/entry/entry_64_compat.S | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/entry/entry_64_compat.S b/arch/x86/entry/entry_64_compat.S
index e1721dafbcb1..aa8a0fa385f3 100644
--- a/arch/x86/entry/entry_64_compat.S
+++ b/arch/x86/entry/entry_64_compat.S
@@ -342,8 +342,7 @@ ENTRY(entry_INT80_compat)
jmp restore_regs_and_iret
END(entry_INT80_compat)
- ALIGN
-GLOBAL(stub32_clone)
+ENTRY(stub32_clone)
/*
* The 32-bit clone ABI is: clone(..., int tls_val, int *child_tidptr).
* The 64-bit clone ABI is: clone(..., int *child_tidptr, int tls_val).
@@ -353,3 +352,4 @@ GLOBAL(stub32_clone)
*/
xchg %r8, %rcx
jmp sys_clone
+ENDPROC(stub32_clone)
--
2.13.0
next prev parent reply other threads:[~2017-05-31 8:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 8:12 [PATCH 1/5] x86: boot/copy, remove unused functions Jiri Slaby
2017-05-31 8:12 ` [PATCH 2/5] x86_32: boot, extract efi_pe_entry from startup_32 Jiri Slaby
2017-06-05 14:20 ` Matt Fleming
2017-05-31 8:12 ` [PATCH 3/5] x86_64: boot, extract efi_pe_entry from startup_64 Jiri Slaby
2017-06-05 14:20 ` Matt Fleming
2017-05-31 8:12 ` [PATCH 4/5] x86: math-emu, add ENDPROC to functions Jiri Slaby
2017-05-31 8:12 ` Jiri Slaby [this message]
2017-06-05 9:14 ` [tip:x86/boot] x86/boot: Remove unused copy_*_gs() functions tip-bot for Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170531081243.5709-5-jslaby@suse.cz \
--to=jslaby@suse.cz \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®