From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751070AbdEaJpe (ORCPT ); Wed, 31 May 2017 05:45:34 -0400 Received: from verein.lst.de ([213.95.11.211]:38795 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750995AbdEaJpd (ORCPT ); Wed, 31 May 2017 05:45:33 -0400 Date: Wed, 31 May 2017 11:45:31 +0200 From: Christoph Hellwig To: Johannes Thumshirn Cc: Christoph Hellwig , Sagi Grimberg , Keith Busch , Linux NVMe Mailinglist , Linux Kernel Mailinglist Subject: Re: [PATCH 2/7] nvmet: add uuid field to nvme_ns and populate via configfs Message-ID: <20170531094531.GB10718@lst.de> References: <4aecbc794651073b2812341dc63e1f2918cc6a82.1496131397.git.jthumshirn@suse.de> <20170530092442.GA16736@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 30, 2017 at 11:48:09AM +0200, Johannes Thumshirn wrote: > On 05/30/2017 11:24 AM, Christoph Hellwig wrote: > > This should be stored as a uuid_t (or rather uuid_be in the current > > kernel, but I'm about to rename it), and use uuid_be_to_bin / uuid_to_bin > > for parsing. > > OK, thought you ask me to do that. Which one do you prefer? I think you'll have to use the old names, unless we get the uuid changes stabilized soon and can pull the branch for it into the nvme / block tree. So go with those for now, and I'll do any after the fact cleanup later.