From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751333AbdEaLBT (ORCPT ); Wed, 31 May 2017 07:01:19 -0400 Received: from mail-sn1nam02on0084.outbound.protection.outlook.com ([104.47.36.84]:34346 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751107AbdEaK73 (ORCPT ); Wed, 31 May 2017 06:59:29 -0400 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=fail action=none header.from=nxp.com; From: To: , CC: , , , , , , , , , , , Laurentiu Tudor Subject: [PATCH 02/10] staging: fsl-mc: fix macros with possible side effects Date: Wed, 31 May 2017 13:58:44 +0300 Message-ID: <20170531105852.22304-3-laurentiu.tudor@nxp.com> X-Mailer: git-send-email 2.9.4 In-Reply-To: <20170531105852.22304-1-laurentiu.tudor@nxp.com> References: <20170531105852.22304-1-laurentiu.tudor@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131407019565611319;(91ab9b29-cfa4-454e-5278-08d120cd25b8);() X-Forefront-Antispam-Report: CIP:192.88.158.2;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(336005)(39380400002)(39840400002)(39850400002)(39400400002)(39410400002)(39860400002)(39450400003)(2980300002)(1109001)(1110001)(339900001)(199003)(189002)(9170700003)(86152003)(104016004)(76176999)(5003940100001)(305945005)(6666003)(38730400002)(2950100002)(105606002)(2876002)(2906002)(86362001)(77096006)(53936002)(4326008)(8656002)(106466001)(54906002)(50986999)(39060400002)(36756003)(50466002)(498600001)(48376002)(8676002)(5660300001)(85426001)(33646002)(81166006)(50226002)(7416002)(47776003)(8936002)(1076002)(189998001)(356003)(97736004)(56340200001);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR03MB2573;H:az84smr01.freescale.net;FPR:;SPF:Fail;MLV:ovrnspm;A:1;MX:1;PTR:InfoDomainNonexistent;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11FD012;1:Ii23556XCMdU6aTyOnvOHiq3UYNIERSQddtfavtV64S6cP1/qcsYyVemRI8NSZ7Wpkm1ju1c9xq2oSFYfqI1yzHKArYPBJHk694rOAevoIxiXrwvbXruq5GH25HuK2uY8v8I3DBlm8gVTjUNm1VrLn+iJHo/LJFdmOOHWjLYZBZzTZRRy/9ySw1yQqy1KAaG//NHYa1zHu7ZHsAsRz2IAo95ouBY/WNwg6qMkspc1ObXl26WXAmSG5uqBy2A45udNa8zJRy8BqgNecaMB3vPXJhzyKeUkW8CllFY9jLaLNr5rD4goaEYs3LLvJHCeSieKgdFCbI73glMEHEB8J56iQkwu567VEzwQkFoIGYx98V/97L4boZ41NrMsgwnI1tsH9fDLtBci/DaZNdJwZhheiKlDCypKP32LE8vEzZ0kou43wCH+K/R7V5YReHpmfNo8VX/4nKEuVTlZnTf6LzGlEL1H3eE5SUdYFwfV4U5hfcPKjyKdX7KHX6vzICtY0oHI2jAW4l5reR8sSjkr2QVvCtpdK6tieaum/1FEy0wmNCWah9pwh3CG0caUjvYMMCCBP025yY5S+VLf7FyGyYEEzqp2HHxUSvJP80PZdcIkjkCMaguM+6Je9YwpOUDi/8CjN5a1lJE7WHrtVKEQ/WgF6wUtldcP6FPRHSrAQM9B+k= MIME-Version: 1.0 Content-Type: text/plain X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR03MB2573: X-MS-Office365-Filtering-Correlation-Id: c515def9-bd1b-49a9-7937-08d4a81414aa X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131430075)(201703131517081);SRVR:MWHPR03MB2573; X-Microsoft-Exchange-Diagnostics: 1;MWHPR03MB2573;3:0+6WcDu9KIgB3uj0Atmxm1FpVZV8u92dHmZCBSDU+kxEsuZKFYZ8KCFPaNljDPsJNG8KOC5RcIIv9GNtsTfUNlDHiqvIE1o6whVpB4OOjQ5Hj+w+dbnd/Jd5EpaYksuv8Ccwj2My/XKRpw/nu3Cx1KW1fiOxhU2fAu5kD/akBGDfnAkP1U3XnORukMniH02t+YxLwVaWGmXd5bKEhoYUMTX/y21lUkTB/NkW/ni+zJuKWCJq0UVTmfi8jNSBnFzGlrUJOnvAEIphtWGR11YwMFsZOQssvpiDEK6VKn4YORliIy6ioMHHFlg2rVGPuHejSTOkJUPTOcMW6Yj2ReRi1TuVtsRFEvoCAJBoJIY+MaI3jdXuvwqzdWlXGSiehDust1BTvZQ48YMHPNbAs1eiLeYAo03vVdKt8TDFfJ2u8f6+UjUUs9nLxdwAVEqsMROx;25:SiN05jsRgGXSY4UvGF0akrpU+mRGwHnZdf1MAr+N9bkFrXIZl5gzmq3jOOW4Z2qK2Y4STnLDhqhO0zTCreqXGpAknTs8D2oMOwEK0lbHBTPotIK4ndV17TJa1MXMnhrsrSGM+dgfyyKeEdTXfOr8YCFuopmMIebkl6RvbTLH84a5ILCl8heVv20FTD2EXj/Hpmy77UKqeKlBzKpgVyM/DHw57RdD/K+wergPKLJkHkspaxQFwZtjPqIGGmHTvUFcEuzv4a/Puj2vWof63XN5EsiK1Ja/wADKO023uIfvLw8dgPFvP7/NyDgZLurTRsSTDhUhVRMNKluC0HhGfn0evh7bMjjNRLGupwxj8DkINgaxbWN85jK6k3Bwq012SIaeQoteaJXmmQSsPOgMYiOV1LR2SYNcOdpGpLiEGIAzbVCRkQvjKImZYp+T8RUrTdqC1xClvzP4av4eZ1WpHOA4CyGNASTNy4NSKug54Lzq9PU= X-Microsoft-Exchange-Diagnostics: 1;MWHPR03MB2573;31:bssXn9ecqLPRqnpO/G99VQnT4LabfT63kN+ORKMn9v4xaF8C2gGW3v8TIUf9WW0XzuIht/RSdzo3e+ujxprw+ap3G6sWHRedVJG18yciM1EQSQYdIYpyBqc8q+P72K4JSgC85totxdESIIsYc2FsHvemg1dayyi6xgh7Psx2dSTT/h09upG5m/fXBYbutd4qvABPxEO5Gsw9O0Xwwa5oCPPSySw2HD0IdeC8xMdBUtRrXRj5ncKRL8vf1eQkelUN4ul/dhUweBj6ooYRZHQY8g== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6095135)(601004)(2401047)(8121501046)(5005006)(13018025)(13016025)(10201501046)(3002001)(93006095)(93001095)(6055026)(6096035)(20161123561025)(20161123556025)(20161123563025)(20161123565025)(201703131430075)(201703131433075)(201703131441075)(201703131448075)(201703161259150)(20161123559100);SRVR:MWHPR03MB2573;BCL:0;PCL:0;RULEID:(400006);SRVR:MWHPR03MB2573; X-Microsoft-Exchange-Diagnostics: 1;MWHPR03MB2573;4:ezyXmr2DkhjrQbsWtD0kJIgHU/R3v27DHOk1hPYdG7/2gdD/LlHGTdAuhjkqxSEiQm7DzfnYl3w/YMqtfwn0stGfR5dvzCpFN5RB3NiR2CP7Aqjc71UXl/Ll1zCnjqagM+POtMF37kfMREgTXWfV4mmOUg1Bd89ulwD/lMhIu9tjf5gn8g69iOCTlqydy5SMbsUfeP+TWeAKwmHg+VvKEyaz6ZX2RdHNYpXkx/qfu3uwa/gcpczuKggfY5sOglp8KvZdPNNosx/pujn33jIo9plkAujtqEsU2z5T/LTN41QmQ2ACM9Jmy1rBPcxPL3jDM09NoLEJPFW5TpPlg8jsGVKShc7fa5o3qMbRKAkt5Tq06sZFXQgAi2WNScR8T50fFRTB4ovz5iAMSz30DqUc401rjW5ecBV5WSiRzVn1EHWtdUCUT2S1P9mfBteFoJhbZ4QPkmiJUAjLI/G0ug0xYR29nG0pQWaG4t03dr0iYcLFYzh0/LspyqAfAyZoMekYjoeqFzYLW1huuhuWh4JqOAiXzlHBsYEtcNKcd7YMSSna3dE8zcxeSHFBfH0u5wf/pD8soDF1fuWApKncN7BRLe5iUca1XN9Yx1TmMj7EIGBhKwsbz7UmdCi0EbFiJr+h0U5yCPd+3ePBnl11USfRB5ng2kW/zeNLQzvUQIWmegGmqG8lQLg0nypJhZbkTmaE9RL1ojpdKGMJG1aDHVZMI41ngbHcVpMI0Z9C9jeWKGYt3UoGX9aaK5RKPnNTYFIVrHr5lOojJZMt2LKUmbPAsgE+TMXK0f0dpGbtnYpfoWy7I4aP+OHKL1SABHqVRFVavMk4nOML7lLDS2Y9UPeu0n5X0Qmn24bK56O6lWH7/QxJL+uJcWrmnusayaheagNHm80s99WodEqW0OHxHRNwnA== X-Forefront-PRVS: 0324C2C0E2 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;MWHPR03MB2573;23:9W92P/8VVCuOXxbS2ct18Wev+d1fLYns59RcJQuOv?= =?us-ascii?Q?mmupgZrUcssSYWmqTxoyWLAZ+0TSB8Ep1P0N/jjXueMGzmYLl6n+KoB1bSkm?= =?us-ascii?Q?FRrv5Ix71JwoaH+uAEU3sPWsGKP5VFVdeRLoPzj9+65sVGwsGfhPoMsuyRhF?= =?us-ascii?Q?H9uSgxmykv5PxfqURo4NzjPZk3zCGYXUgAAoQ/fcFqWme/yQO9UUvg3gZtEL?= =?us-ascii?Q?aIioDz9vz2QmYVmFBH53G9dUQ7pQLUcOklzN3yhTFwTrIW28k1QuaNIEQuYd?= =?us-ascii?Q?kyzR5GCK6zVl5cuk8cAZrfMvlrQ1IctjMNG3J3rHXmITjv/BfxsEJX0C5tE0?= =?us-ascii?Q?XXDaVHg2kLVM83ngoFr4f7LJ7m4rxrzOxO7HB9XG+tQMhtjE5CRv7BtmCMgZ?= =?us-ascii?Q?LoUe7JVwB0whjlW9L+muWiepfcV9P6BY6PkSKVgdo/086P8kVv9tlX5RDoId?= =?us-ascii?Q?AIgjyCv1lE31TutKv2kzO7Cyucw1WVXCWt14VOP1DXWG60SFYeCsnM/bcgIB?= =?us-ascii?Q?ElDGISGQv6ub3trEu+5YO+X9I2uOqb/qZF1gKW3X8cIcsQ/xH0yoZteN0TJm?= =?us-ascii?Q?kczifF62Rqw38YpqTD6c4cuIInxDwUOx0CYHrHs5hpjtRm591uRGTfKJNE6L?= =?us-ascii?Q?smZe4hqfbUSyV9FQwrnHxvgDejlCu8rIqgVnoUgJE6Kg7JwcvC+Ki6tRrjOh?= =?us-ascii?Q?htuqfejd4mds3V4fkkQHjIoIzS4/rZN7KyH5xuU19Gy/pyKy34h87LpbgGpp?= =?us-ascii?Q?ei+Juih+lM0MaMW9ksOzPr5bmUoedGO9hZd7wv69FK1YeGWgx9+JFXwJM9PA?= =?us-ascii?Q?QzoEU4ro6QrhX31rAyyvKsrVpVkulhek8MlOHx2SymcQL19IWZGWpmHZiNi5?= =?us-ascii?Q?3DvqH6RLH5ER8veAU63PrRvIBCn9go1VFp1yCShBcqLTM+2GuvEkmfq1nR3X?= =?us-ascii?Q?Hfh/cBOVYEp6hjfiB2NgtgqH+gyPpDgkIMz2uzQge7BIbZU13W0NdFe7IFxV?= =?us-ascii?Q?AqVNg7cs+dd3c6MIDJsLxImMNEV3UM0q/tWdmt0jO0yoKQHcejGFO3K3/MSC?= =?us-ascii?Q?kGMG2E7+7F2Zj0lNYuSoTBEx+K96kNMZK3s03flffCYHf0b/ELeprilvweL7?= =?us-ascii?Q?qFKeV4YZiD9S2txTMs9KbnOfYfH2SZlJZM56NmPyY6W+H4FbbaH7viTsIFXq?= =?us-ascii?Q?LEjLgPrpNEMOx9KF+/Y/kQBCNHCgmhKpjgcLdamk0HglUP5zGrCLevo6GPau?= =?us-ascii?Q?YqBHJ61AbL6neLiG6QS0abg1Zfbhgv3Fpm7KHGjdz0PttAC+RFXuTFjMN6hi?= =?us-ascii?Q?GPpxVomrwfeCFdUmYAAtX0P6b/jBRRYD8lnD+K9LPVU?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR03MB2573;6:FFaafeSf4Pb7wxRMGv8Dlw9ym5YGoSE+u081MFdCVSY+9ueLAJAaH2sdBsDnjrINobXY0SXdKhWokR9AXSqoWCHdaMhPjYfy5KJ1gKc+h84QZeuOdZABZmYUQ875WxWio4ZdC/xArv/x/NA3y4pB8LdRxZbawHGLRW6QLzxJv+gxCh2awAkKiKflvJdqiSNSv7aHARbomasOa1VlfxZ/RJ04qf6kALFfIecepZ13yefXKwDB/B9RYxmidwLiKACpVnAXKDtCP8fYe6pg02gG2M7/Gj2xtKFbkmhxq1vz1nGXRz7/8tJgVVj5fXftEMXAuLWnGEYs/SWNgunoJMWggvkvVuQT+AzwctNhqnUiaCHM1yrek6aSpTW4kbn4IZet1pKwG4KnQF1ZRw48AzUNoDe2dYHcf4KfnYsjnANtyInZNc7+8L5oPnmhLtD6V95kTplRvw1SDWyCzulWdfDxT3Vi3NAlyx8/3inZSwKeTkzOtRKIHXW/Bo+yQHhN4KXcl58WDqfbbsrrf8FQDlaltA==;5:qMfmFSSiCDwZ5rhOknISC2NHbIhW7mxI402hdiiv9j4KmmiIe/7Q82I7ZeM2adSm6yYQLKSLkIZ+VzqkKNcZ1fyWrDJdGLA+i7Dc7biC/pVVQzuJ7uF8gqsSIKepLBEfNSRYbfhZueAIKn7i4JP/rTz/VuLMSr1fm38MKY3pxYi+JmMA89dH7xaLCGPDosWW;24:03V9i/7Aj80hjEZufcntw2i8RvpkXrmAneJSCz3XqrXShlLKWhqN7xdvhwmjdnjOT+tSTQtj8NEzPcbezy2dFyM/eRtfM0pSXWd/BJbmFU0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;MWHPR03MB2573;7:Zzh21sIr2G60qOti0Ex5LBd3l0VErzLKEWy1v0vDj/4nkhuQ9uT1savGNcL+ITuek5fJsj2PBBXbPeyitgNmDElAXnP2WNNR6od0oXgI14CgCriVme6jtuMXFJELsZ/m6L0CMch7GVer0MppD6oN+61+gCmjgW75jrs4YlohEPciCAnh6WWxnbLo0PW3i9+wiozFac/D978qng8er88Dwd8P6H2cZiKd29q8hdr4ofV6qdCrK6SWJuwwvDVP7qDimvBBfYYSvKZ0G7Era1Lbf3cix8tBz0G2HFREPJJ50fvRVhZfhMYDvW2JkKh4uO119xRx4pa0JoJuDNeH5g4hsQ== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2017 10:59:16.2803 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[192.88.158.2];Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2573 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Laurentiu Tudor Several macros were triggering this checkpatch.pl warning: "Macro argument reuse '$arg' - possible side-effects?" Fix the warning by avoiding multiple macro argument use. Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-mc/bus/dprc-driver.c | 10 +++++++--- drivers/staging/fsl-mc/bus/fsl-mc-allocator.c | 11 +++++++---- 2 files changed, 14 insertions(+), 7 deletions(-) diff --git a/drivers/staging/fsl-mc/bus/dprc-driver.c b/drivers/staging/fsl-mc/bus/dprc-driver.c index d723c69..39c9a3b 100644 --- a/drivers/staging/fsl-mc/bus/dprc-driver.c +++ b/drivers/staging/fsl-mc/bus/dprc-driver.c @@ -21,9 +21,13 @@ #define FSL_MC_DPRC_DRIVER_NAME "fsl_mc_dprc" -#define FSL_MC_DEVICE_MATCH(_mc_dev, _obj_desc) \ - (strcmp((_mc_dev)->obj_desc.type, (_obj_desc)->type) == 0 && \ - (_mc_dev)->obj_desc.id == (_obj_desc)->id) +#define FSL_MC_DEVICE_MATCH(_mc_dev, _obj_desc) \ +({ \ + struct fsl_mc_device *__mc_dev = _mc_dev; \ + struct dprc_obj_desc *__obj_desc = _obj_desc; \ + (strcmp(__mc_dev->obj_desc.type, __obj_desc->type) == 0 && \ + __mc_dev->obj_desc.id == __obj_desc->id); \ +}) struct dprc_child_objs { int child_count; diff --git a/drivers/staging/fsl-mc/bus/fsl-mc-allocator.c b/drivers/staging/fsl-mc/bus/fsl-mc-allocator.c index ce07096..d3def40 100644 --- a/drivers/staging/fsl-mc/bus/fsl-mc-allocator.c +++ b/drivers/staging/fsl-mc/bus/fsl-mc-allocator.c @@ -17,10 +17,13 @@ #include "dpcon-cmd.h" #include "fsl-mc-private.h" -#define FSL_MC_IS_ALLOCATABLE(_obj_type) \ - (strcmp(_obj_type, "dpbp") == 0 || \ - strcmp(_obj_type, "dpmcp") == 0 || \ - strcmp(_obj_type, "dpcon") == 0) +#define FSL_MC_IS_ALLOCATABLE(_obj_type) \ +({ \ + const char *__obj_type = _obj_type; \ + (strcmp(__obj_type, "dpbp") == 0 || \ + strcmp(__obj_type, "dpmcp") == 0 || \ + strcmp(__obj_type, "dpcon") == 0); \ +}) /** * fsl_mc_resource_pool_add_device - add allocatable object to a resource -- 2.9.4