From: <laurentiu.tudor@nxp.com>
To: <gregkh@linuxfoundation.org>, <stuyoder@gmail.com>
Cc: <devel@driverdev.osuosl.org>, <linux-kernel@vger.kernel.org>,
<agraf@suse.de>, <arnd@arndb.de>, <ioana.ciornei@nxp.com>,
<ruxandra.radulescu@nxp.com>, <bharat.bhushan@nxp.com>,
<catalin.horghidan@nxp.com>, <leoyang.li@nxp.com>,
<roy.pledge@nxp.com>, <linux-arm-kernel@lists.infradead.org>,
Laurentiu Tudor <laurentiu.tudor@nxp.com>
Subject: [PATCH 03/10] staging: fsl-mc: simplify couple of deallocations
Date: Wed, 31 May 2017 13:58:45 +0300 [thread overview]
Message-ID: <20170531105852.22304-4-laurentiu.tudor@nxp.com> (raw)
In-Reply-To: <20170531105852.22304-1-laurentiu.tudor@nxp.com>
From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Simplify a couple of deallocations code paths. This also
fixes these checkpatch.pl false positives:
"WARNING: kfree(NULL) is safe and this check is
probably not required"
Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
---
drivers/staging/fsl-mc/bus/fsl-mc-bus.c | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/fsl-mc/bus/fsl-mc-bus.c b/drivers/staging/fsl-mc/bus/fsl-mc-bus.c
index 50eb415..7b48ade 100644
--- a/drivers/staging/fsl-mc/bus/fsl-mc-bus.c
+++ b/drivers/staging/fsl-mc/bus/fsl-mc-bus.c
@@ -420,15 +420,11 @@ bool fsl_mc_is_root_dprc(struct device *dev)
static void fsl_mc_device_release(struct device *dev)
{
struct fsl_mc_device *mc_dev = to_fsl_mc_device(dev);
- struct fsl_mc_bus *mc_bus = NULL;
kfree(mc_dev->regions);
if (strcmp(mc_dev->obj_desc.type, "dprc") == 0)
- mc_bus = to_fsl_mc_bus(mc_dev);
-
- if (mc_bus)
- kfree(mc_bus);
+ kfree(to_fsl_mc_bus(mc_dev));
else
kfree(mc_dev);
}
@@ -559,10 +555,8 @@ int fsl_mc_device_add(struct dprc_obj_desc *obj_desc,
error_cleanup_dev:
kfree(mc_dev->regions);
- if (mc_bus)
- kfree(mc_bus);
- else
- kfree(mc_dev);
+ kfree(mc_bus);
+ kfree(mc_dev);
return error;
}
--
2.9.4
next prev parent reply other threads:[~2017-05-31 10:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 10:58 [PATCH v6 00/10] staging: fsl-mc: move bus driver out of staging laurentiu.tudor
2017-05-31 10:58 ` [PATCH 01/10] staging: fsl-mc: enclose macro params in parens laurentiu.tudor
2017-06-03 8:41 ` Greg KH
2017-06-06 12:03 ` Laurentiu Tudor
2017-05-31 10:58 ` [PATCH 02/10] staging: fsl-mc: fix macros with possible side effects laurentiu.tudor
2017-05-31 10:58 ` laurentiu.tudor [this message]
2017-05-31 10:58 ` [PATCH 04/10] staging: fsl-mc: drop a few useless #includes laurentiu.tudor
2017-05-31 10:58 ` [PATCH 05/10] staging: fsl-mc: remove extra blank line laurentiu.tudor
2017-05-31 10:58 ` [PATCH 06/10] staging: fsl-mc: drop unused forward declaration laurentiu.tudor
2017-05-31 10:58 ` [PATCH v2 07/10] staging: fsl-mc: add binding path to MAINTAINERS laurentiu.tudor
2017-05-31 10:58 ` [PATCH 08/10] staging: fsl-mc: drop reference to restool laurentiu.tudor
2017-05-31 10:58 ` [PATCH 09/10] staging: fsl-mc: add reference to mc-bus DT binding laurentiu.tudor
2017-05-31 10:58 ` [PATCH v4 10/10] staging: fsl-mc: move bus driver out of staging laurentiu.tudor
2017-05-31 11:15 ` Marc Zyngier
2017-05-31 11:31 ` Laurentiu Tudor
2017-06-03 8:40 ` Greg KH
2017-06-06 14:03 ` Laurentiu Tudor
2017-06-06 14:20 ` Greg KH
2017-06-06 14:23 ` Laurentiu Tudor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170531105852.22304-4-laurentiu.tudor@nxp.com \
--to=laurentiu.tudor@nxp.com \
--cc=agraf@suse.de \
--cc=arnd@arndb.de \
--cc=bharat.bhushan@nxp.com \
--cc=catalin.horghidan@nxp.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=ioana.ciornei@nxp.com \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roy.pledge@nxp.com \
--cc=ruxandra.radulescu@nxp.com \
--cc=stuyoder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®