From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751205AbdEaUyG (ORCPT ); Wed, 31 May 2017 16:54:06 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:51728 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751053AbdEaUyF (ORCPT ); Wed, 31 May 2017 16:54:05 -0400 Date: Wed, 31 May 2017 13:54:04 -0700 From: Andrew Morton To: Oleksij Rempel Cc: linux@rempel-privat.de, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/6] kernel/reboot.c: export pm_power_off_prepare Message-Id: <20170531135404.9110be8a08fbcf83ee9e7939@linux-foundation.org> In-Reply-To: <20170531061457.23744-4-o.rempel@pengutronix.de> References: <20170531061457.23744-1-o.rempel@pengutronix.de> <20170531061457.23744-4-o.rempel@pengutronix.de> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 31 May 2017 08:14:54 +0200 Oleksij Rempel wrote: > we need it to preconfigure PMIC to properly power off the system. Who is "we", what is a "PMIC", what architecture is affected and where is this code which references pm_power_off_prepare? > --- a/kernel/reboot.c > +++ b/kernel/reboot.c > @@ -49,6 +49,7 @@ int reboot_force; > */ > > void (*pm_power_off_prepare)(void); > +EXPORT_SYMBOL(pm_power_off_prepare); > > /** > * emergency_restart - reboot the system > -- > 2.11.0