From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751332AbdEaRP3 (ORCPT <rfc822;w@1wt.eu>);
        Wed, 31 May 2017 13:15:29 -0400
Received: from smtp.codeaurora.org ([198.145.29.96]:56328 "EHLO
        smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751150AbdEaROA (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 31 May 2017 13:14:00 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 0AB8F605A4
Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org
Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org
Date: Wed, 31 May 2017 10:13:58 -0700
From: Stephen Boyd <sboyd@codeaurora.org>
To: Kiran Gunda <kgunda@codeaurora.org>
Cc: Abhijeet Dharmapurikar <adharmap@codeaurora.org>,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        David Collins <collinsd@codeaurora.org>,
        Subbaraman Narayanamurthy <subbaram@codeaurora.org>,
        linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        adharmap@quicinc.com, aghayal@qti.qualcomm.com,
        Nicholas Troast <ntroast@codeaurora.org>
Subject: Re: [PATCH V1 11/15] spmi: spmi-pmic-arb: enable the SPMI interrupt
 as a wakeup source
Message-ID: <20170531171358.GC20170@codeaurora.org>
References: <1496147943-25822-1-git-send-email-kgunda@codeaurora.org>
 <1496147943-25822-12-git-send-email-kgunda@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1496147943-25822-12-git-send-email-kgunda@codeaurora.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 05/30, Kiran Gunda wrote:
> Currently the SPMI interrupt will not wake the device. Enable this
> interrupt as a wakeup source.
> 
> Signed-off-by: Nicholas Troast <ntroast@codeaurora.org>
> Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
> ---
>  drivers/spmi/spmi-pmic-arb.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c
> index 0deac33..2afe359 100644
> --- a/drivers/spmi/spmi-pmic-arb.c
> +++ b/drivers/spmi/spmi-pmic-arb.c
> @@ -1140,6 +1140,7 @@ static int spmi_pmic_arb_probe(struct platform_device *pdev)
>  	}
>  
>  	irq_set_chained_handler_and_data(pa->irq, pmic_arb_chained_irq, pa);
> +	enable_irq_wake(pa->irq);

Why don't we do this through an irq_set_wake callback in the
irqchip? That way, we don't mark this irq as wakeup if any child
irqs aren't marked as wakeup.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project