mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Lai Jiangshan <jiangshanlai@gmail.com>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: single-threaded wq lockdep is broken
Date: Wed, 31 May 2017 14:19:58 -0400	[thread overview]
Message-ID: <20170531181958.GA4795@htj.duckdns.org> (raw)
In-Reply-To: <1495999993.3578.1.camel@sipsolutions.net>

Hello, Johannes.

On Sun, May 28, 2017 at 09:33:13PM +0200, Johannes Berg wrote:
> I suspect this is a long-standing bug introduced by all the pool rework
> you did at some point, but I don't really know nor can I figure out how
> to fix it right now. I guess it could possibly also be a lockdep issue,
> or an issue in how it's used, but I definitely know that this used to
> work (i.e. warn) back when I introduced the lockdep checking to the WQ

Hah, didn't know this worked.

> code. I was actually bitten by a bug like this, and erroneously
> dismissed it as not being the case because lockdep hadn't warned (and
> the actual deadlock debug output is basically not existent).
> 
> In any case, the following code really should result in a warning from
> lockdep, but doesn't. If you comment in the #define DEADLOCK, it will
> actually cause a deadlock :)
...
> static void w1_wk(struct work_struct *w)
> {
> 	mutex_lock(&mtx);
> 	msleep(100);
> 	mutex_unlock(&mtx);
> }
...
> static int init(void)
> {
> 	wq = create_singlethread_workqueue("test");
> 	if (!wq)
> 		return -ENOMEM;
> 	INIT_WORK(&w1, w1_wk);
> 	INIT_WORK(&w2, w2_wk);
> 
> #ifdef DEADLOCK
> 	queue_work(wq, &w1);
> 	queue_work(wq, &w2);
> #endif
> 	mutex_lock(&mtx);
> 	flush_work(&w2);
> 	mutex_unlock(&mtx);

So, it used to always create dependency between work items on
singlethread workqueues according to their queeing order?  It
shouldn't be difficult to fix.  I'll dig through the history and see
what happened.

Thanks.

-- 
tejun

  parent reply	other threads:[~2017-05-31 18:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-28 19:33 Johannes Berg
2017-05-31  8:34 ` Lai Jiangshan
2017-05-31  8:36   ` Johannes Berg
2017-05-31  8:47     ` Johannes Berg
2017-06-02  7:03     ` Lai Jiangshan
2017-06-02  8:51       ` Johannes Berg
2017-05-31 18:19 ` Tejun Heo [this message]
2017-05-31 19:15   ` Johannes Berg
2017-06-13 16:06 ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170531181958.GA4795@htj.duckdns.org \
    --to=tj@kernel.org \
    --cc=jiangshanlai@gmail.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®