From: Bjorn Helgaas <helgaas@kernel.org>
To: Mason <slash.tmp@free.fr>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Marc Zyngier <marc.zyngier@arm.com>,
linux-pci <linux-pci@vger.kernel.org>,
Liviu Dudau <liviu.dudau@arm.com>,
LKML <linux-kernel@vger.kernel.org>,
David Laight <david.laight@aculab.com>,
Thomas Gleixner <tglx@linutronix.de>,
Robin Murphy <robin.murphy@arm.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
Subject: Re: [PATCH v4 1/2] PCI: Add tango MSI controller support
Date: Wed, 31 May 2017 14:12:58 -0500 [thread overview]
Message-ID: <20170531191258.GA18454@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <20170531190037.GA18084@bhelgaas-glaptop.roam.corp.google.com>
On Wed, May 31, 2017 at 02:00:37PM -0500, Bjorn Helgaas wrote:
> On Wed, May 31, 2017 at 08:49:04PM +0200, Mason wrote:
> > On 31/05/2017 19:34, Bjorn Helgaas wrote:
> > ...
>
> > > This would be more an IRQ patch than a PCI patch, but if I were
> > > reviewing it, I would look for assurance that *all* the no-op
> > > .irq_set_affinity callbacks were cleaned up, not just those in
> > > drivers/pci/host.
> >
> > Are you saying the patch is *wrong* if not all "do-nothing"
> > callbacks are cleaned up?
>
> I'm saying that (1) this probably wouldn't be applied via the PCI
> tree, and (2) if it *were* applied via PCI, I would ask that all the
> no-op callbacks were cleaned up at the same time.
>
> Huh, that sounds a lot like what I wrote above. Was I unclear?
I'm afraid this sounded snarky, which isn't my intention. It seems
like there's a useful patch here, and I didn't want to see it get
ignored for lack of following the usual process. If this is all
obvious to you, my apologies and please ignore my suggestion.
Bjorn
next prev parent reply other threads:[~2017-05-31 19:13 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 14:24 [PATCH v4 0/2] Tango PCIe " Marc Gonzalez
2017-04-20 14:28 ` [PATCH v4 1/2] PCI: Add tango MSI " Marc Gonzalez
2017-05-17 14:56 ` Marc Gonzalez
2017-05-23 17:03 ` Bjorn Helgaas
2017-05-23 17:54 ` Mason
2017-05-23 18:03 ` Robin Murphy
2017-05-23 19:15 ` Mason
2017-05-24 10:00 ` Robin Murphy
2017-05-24 10:22 ` Marc Zyngier
2017-05-31 14:18 ` Mason
2017-05-31 17:34 ` Bjorn Helgaas
2017-05-31 18:49 ` Mason
2017-05-31 19:00 ` Bjorn Helgaas
2017-05-31 19:12 ` Bjorn Helgaas [this message]
2017-05-31 19:27 ` Mason
2017-05-31 20:04 ` Bjorn Helgaas
2017-05-31 21:55 ` Mason
2017-05-25 8:37 ` Marc Zyngier
2017-05-31 7:32 ` Marc Gonzalez
2017-04-20 14:31 ` [PATCH v4 2/2] PCI: Add tango PCIe host bridge support Marc Gonzalez
2017-05-23 17:24 ` Bjorn Helgaas
2017-05-23 17:43 ` Mason
2017-05-23 18:35 ` Bjorn Helgaas
2017-05-23 19:29 ` Mason
2017-05-25 8:48 ` Marc Zyngier
2017-05-25 12:00 ` Mason
2017-05-25 12:23 ` Marc Zyngier
2017-05-25 12:41 ` Mason
2017-05-25 13:20 ` Marc Zyngier
2017-05-15 8:16 ` [PATCH v4 0/2] Tango PCIe controller support Marc Gonzalez
2017-05-23 17:17 ` Bjorn Helgaas
2017-05-23 18:07 ` Mason
2017-05-23 18:30 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170531191258.GA18454@bhelgaas-glaptop.roam.corp.google.com \
--to=helgaas@kernel.org \
--cc=david.laight@aculab.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=marc.zyngier@arm.com \
--cc=marc_gonzalez@sigmadesigns.com \
--cc=robin.murphy@arm.com \
--cc=slash.tmp@free.fr \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®