From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751056AbdEaThy (ORCPT ); Wed, 31 May 2017 15:37:54 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:34533 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750898AbdEaThw (ORCPT ); Wed, 31 May 2017 15:37:52 -0400 Date: Wed, 31 May 2017 21:37:48 +0200 From: Krzysztof Kozlowski To: Arnd Bergmann Cc: Kukjin Kim , Eric Anholt , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: s3c64xx: don't select ARM_AMBA from S3C64XX_PL080 Message-ID: <20170531193748.7cyyxy3oflksdp2m@kozik-lap> References: <20170524155845.1778223-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170524155845.1778223-1-arnd@arndb.de> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 24, 2017 at 05:58:34PM +0200, Arnd Bergmann wrote: > While trying a fix a build warning unrelated to s3c64xx, I ran into > a circular dependency: > > drivers/i2c/Kconfig:7: symbol I2C is selected by FB_DDC > drivers/video/fbdev/Kconfig:63: symbol FB_DDC is selected by FB_CYBER2000_DDC > drivers/video/fbdev/Kconfig:381: symbol FB_CYBER2000_DDC depends on FB_CYBER2000 > drivers/video/fbdev/Kconfig:369: symbol FB_CYBER2000 depends on FB > drivers/video/fbdev/Kconfig:5: symbol FB is selected by DRM_KMS_FB_HELPER > drivers/gpu/drm/Kconfig:72: symbol DRM_KMS_FB_HELPER is selected by DRM_KMS_CMA_HELPER > drivers/gpu/drm/Kconfig:137: symbol DRM_KMS_CMA_HELPER is selected by DRM_PL111 > drivers/gpu/drm/pl111/Kconfig:1: symbol DRM_PL111 depends on ARM_AMBA > drivers/amba/Kconfig:1: symbol ARM_AMBA is selected by S3C64XX_PL080 > arch/arm/mach-s3c64xx/Kconfig:42: symbol S3C64XX_PL080 default value contains DMADEVICES > drivers/dma/Kconfig:5: symbol DMADEVICES is selected by SND_SOC_SH4_SIU > sound/soc/sh/Kconfig:29: symbol SND_SOC_SH4_SIU is selected by SND_SIU_MIGOR > sound/soc/sh/Kconfig:59: symbol SND_SIU_MIGOR depends on I2C > > The I2C and FB dependencies are hard to untangle, but I notice that > S3C64XX_PL080 selecting ARM_AMBA is one piece of the puzzle that > can easily be avoided, as ARCH_S3C64XX already select ARM_AMBA. > Removing the redundant 'select' now can help us in the future if we > run into a variation of the same dependency. > > Signed-off-by: Arnd Bergmann > --- > Please apply this to the samsung tree > --- > arch/arm/mach-s3c64xx/Kconfig | 1 - > 1 file changed, 1 deletion(-) > Thanks, applied. Best regards, Krzysztof