From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751205AbdEaUEb (ORCPT ); Wed, 31 May 2017 16:04:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:53934 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751009AbdEaUE3 (ORCPT ); Wed, 31 May 2017 16:04:29 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 31135214EC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=helgaas@kernel.org Date: Wed, 31 May 2017 15:04:24 -0500 From: Bjorn Helgaas To: Mason Cc: Lorenzo Pieralisi , Marc Zyngier , linux-pci , Liviu Dudau , LKML , David Laight , Thomas Gleixner , Robin Murphy , Linux ARM , Marc Gonzalez Subject: Re: [PATCH v4 1/2] PCI: Add tango MSI controller support Message-ID: <20170531200424.GA23171@bhelgaas-glaptop.roam.corp.google.com> References: <20170531173414.GB4496@bhelgaas-glaptop.roam.corp.google.com> <4885137f-7c1c-5742-4f66-f48c32ce7abb@free.fr> <20170531190037.GA18084@bhelgaas-glaptop.roam.corp.google.com> <20170531191258.GA18454@bhelgaas-glaptop.roam.corp.google.com> <74d6d867-313a-2304-9753-9739ad4703a8@free.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <74d6d867-313a-2304-9753-9739ad4703a8@free.fr> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 31, 2017 at 09:27:50PM +0200, Mason wrote: > On 31/05/2017 21:12, Bjorn Helgaas wrote: > > On Wed, May 31, 2017 at 02:00:37PM -0500, Bjorn Helgaas wrote: > >> On Wed, May 31, 2017 at 08:49:04PM +0200, Mason wrote: > >>> On 31/05/2017 19:34, Bjorn Helgaas wrote: > >>> ... > >> > >>>> This would be more an IRQ patch than a PCI patch, but if I were > >>>> reviewing it, I would look for assurance that *all* the no-op > >>>> .irq_set_affinity callbacks were cleaned up, not just those in > >>>> drivers/pci/host. > >>> > >>> Are you saying the patch is *wrong* if not all "do-nothing" > >>> callbacks are cleaned up? > >> > >> I'm saying that (1) this probably wouldn't be applied via the PCI > >> tree, and (2) if it *were* applied via PCI, I would ask that all the > >> no-op callbacks were cleaned up at the same time. > >> > >> Huh, that sounds a lot like what I wrote above. Was I unclear? > > > > I'm afraid this sounded snarky, which isn't my intention. It seems > > like there's a useful patch here, and I didn't want to see it get > > ignored for lack of following the usual process. If this is all > > obvious to you, my apologies and please ignore my suggestion. > > Thanks for clearing things up. I had indeed assumed from > your first reply that the patch was pointless. > > Writing a script locating all candidates will be an > interesting exercise. Cscope only sees 94 definitions of irq_set_affinity. I know *I* could never write a script faster than looking at them manually. While doing that, I noticed irq_chip_set_affinity_parent(), which is used in 14 cases and appears similar to your patch.