From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751192AbdEaWHc (ORCPT ); Wed, 31 May 2017 18:07:32 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:38146 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751000AbdEaWHa (ORCPT ); Wed, 31 May 2017 18:07:30 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 9D0E060128 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Wed, 31 May 2017 15:07:29 -0700 From: Stephen Boyd To: Kiran Gunda Cc: Abhijeet Dharmapurikar , Christophe JAILLET , Greg Kroah-Hartman , Subbaraman Narayanamurthy , David Collins , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, adharmap@quicinc.com, aghayal@qti.qualcomm.com Subject: Re: [PATCH V1 15/15] spmi: pmic-arb: instantiate spmi_devices at arch_initcall Message-ID: <20170531220729.GI20170@codeaurora.org> References: <1496147943-25822-1-git-send-email-kgunda@codeaurora.org> <1496147943-25822-16-git-send-email-kgunda@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1496147943-25822-16-git-send-email-kgunda@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/30, Kiran Gunda wrote: > @@ -1384,7 +1384,12 @@ static int spmi_pmic_arb_remove(struct platform_device *pdev) > .of_match_table = spmi_pmic_arb_match_table, > }, > }; > -module_platform_driver(spmi_pmic_arb_driver); > + > +int __init spmi_pmic_arb_init(void) Missing static. > +{ > + return platform_driver_register(&spmi_pmic_arb_driver); > +} > +arch_initcall(spmi_pmic_arb_init); We also lost module removal. Probably nobody tests it, but still no mention of that in commit text. I'm not sure we need this at all though. Is there something that needs to probe early? Indicating what that is in the commit text would be helpful. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project