From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751364AbdFABIV convert rfc822-to-8bit (ORCPT ); Wed, 31 May 2017 21:08:21 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:33496 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750977AbdFABIT (ORCPT ); Wed, 31 May 2017 21:08:19 -0400 X-AuditID: b6c32a38-f791a6d0000031eb-bd-592f6901080e Mime-Version: 1.0 Subject: RE: Re: FW: [4.12 regression] "cpufreq: intel_pstate: Active mode P-state limits rework" Reply-To: jongman.heo@samsung.com From: Jongman Heo To: "Rafael J. Wysocki" CC: Linux PM , LKML , Srinivas Pandruvada X-Priority: 3 X-Content-Kind-Code: NORMAL In-Reply-To: <3772609.tskOqDLWI3@aspire.rjw.lan> X-Drm-Type: N,general X-EPLocale: ko_KR.EUC-KR X-EPWebmail-Msg-Type: personal X-Msg-Generator: Mail X-Msg-Type: PERSONAL X-Reply-Demand: N Illegal-Object: Syntax error in X-Sender: address found on vger.kernel.org: X-Sender: =?utf-8?B?U2Ftc3VuZyBFbGVjdHJvbmljcxtTVEIgUiY=?= ^-Extraneous program text X-Sender-IP: 10.89.16.209 X-Local-Sender: =?UTF-8?B?7ZeI7KKF66eMG1NUQuqwnOuwnOq3uOujuShWRCkb7IK87ISx7KCE7J6Q?= =?UTF-8?B?G1ByaW5jaXBhbCBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?Sm9uZ21hbiBIZW8bU1RCIFImRCBHcm91cBtTYW1zdW5nIEVsZWN0cm9u?= =?UTF-8?B?aWNzG1ByaW5jaXBhbCBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwGxtDMTBLMDgwMw==?= Message-ID: <20170601010816epcms1p16cded9ef0657a694c5a7a73ab723ecd7@epcms1p1> Date: Thu, 01 Jun 2017 01:08:16 +0000 X-CMS-MailID: 20170601010816epcms1p16cded9ef0657a694c5a7a73ab723ecd7 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="utf-8" X-MTR: 20170601010816epcms1p16cded9ef0657a694c5a7a73ab723ecd7 CMS-TYPE: 101P X-Brightmail-Tracker: H4sIAAAAAAAAA02Se0hTYRjG+zzbPJqL09R6NRA7afddzth0hpMoKcEEw4TMwk7zaw53sZ1p GVgSmblWaHYxSbPsYheyrNm0otCSWhfsfsUSLSSxEpPIsNpxE/vvx8PzvDdekpB8F4aTBrMN W82skRYFCprb58mlyCDPUOxxB2qetR4VaYb23kGahw+eCjXl9Zf9FwuSau+vTLr6olSQNNQU kUqswfE5mM3G1khs1lmyDWa9lk5Oy1qapY5RMFImThNLR5pZE9bSiStSpcsMRk8zOrKANeZ7 pFSW42h5QrzVkm/DkTkWzqalMxlGKWMUsTKlUilTxa5bpFR7LOtxzom9s/MuhW+5d/aMqBhV hNlRAAmUCnrvVgq9PA06uxpFPEsoF4KDFxLsiCTF1FQYdQXzGEzpoNud63XMhNLBCgHPwZQU jl3s8eNZRC2AMmfVGId4uMbhJuwokCSoPQiOlJT7eVuJoar0k8DLM+DaGSfiOYBSgOPRb+TV Q+HN+QF/LwO87+/0ZSPg0PAFYtzzreOYzx8CJV2PfPpU+Pjruk83wSX7F182DJxlV3z6dnDt 6xPxwwG1E8GN9gohvyRQcnB30LxHTKWAo+bw2EkEVDS0V/b5sonw5JZ9bDbCs+Tp4/0EHyWo edDYKvdatGB/XerntUyBr8MOX/Vo6BzdWI6iqiduW/1fneqJOnWIOIem4TzOpMcck6eScayJ yzfrZTqLqQmNfdt8jQvdeLyiDVEkooPE1BNZhkTIFnCFpjYEJEGHiFNmyzMk4my2cCu2WrKs +UbMtSG1Z50KIjxUZ/H8rtmWxajiFKoYpVrNKDQqero4tPHlagmlZ204F+M8bB3P+ZEB4cUo qLFA2L9kzkBzS4Nem7n7Z9Q+aWKR4a27verUsLg719nnaBjpHdyxfOnNF23+THP6857C3gbj LkWnqu7P6ZHb2ThN3dxdD7Uutf+7ss2cTvp54dG16ZPD3teln+x3lfw9DkEHPvyYJEvetn9D kV3CbqpqmTVX5EwdXfUQve14lUYLuByWmU9YOfYf2I+734MDAAA= DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20170516042313epcms1p5523f4e3e1ae608eaf0327be0242ee46e X-RootMTR: 20170516042313epcms1p5523f4e3e1ae608eaf0327be0242ee46e References: <3772609.tskOqDLWI3@aspire.rjw.lan> <20170516042511epcms1p33c79e84f62d4b1d37cf227d2379bbecf@epcms1p3> <20170529021852epcms1p66b2e89d2aec7988e00fb64c41a48a839@epcms1p6> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > >--------- Original Message --------- >Sender : Rafael J. Wysocki >Date : 2017-06-01 08:58 (GMT+9) >Title : Re: FW: [4.12 regression] "cpufreq: intel_pstate: Active mode P-state limits rework" > >On Monday, May 29, 2017 02:18:52 AM Jongman Heo wrote: >> >> Hi, >> >> FYI, 4.12-rc3 still has this issue. >> >> >> --------- Original Message --------- >> Sender : 허종만 >> Date : 2017-05-16 13:25 (GMT+9) >> Title : [4.12 regression] "cpufreq: intel_pstate: Active mode P-state limits rework" >> >> >> Hi, >> >> With 4.12-rc1 (Linus git), booting fails due to kernel panic, at intel_pstate_register_driver+0x56/0x110. >> I can't copy the whole trace from the graphic console, it looks like below. >> >> Call Trace: >> intel_pstate_init >> intel_pstate_setup >> do_one_initcall >> set_debug_rodata >> kernel_init_freeable >> rest_init >> kernel_init >> ret_from_fork >> Code: ... >> RIP: intel_pstate_register_driver+0x56/0x110 RSP: ffffa3a98000bd80 >> ... > >I guess this is a division by 0 due to the unmet assumption that the denominator >in min_perf_pct_min() will always be nonzero. > >If this guess is correct, the patch below should help, so can you please test it? > >Thanks, >Rafael > > >--- > drivers/cpufreq/intel_pstate.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >Index: linux-pm/drivers/cpufreq/intel_pstate.c >=================================================================== >--- linux-pm.orig/drivers/cpufreq/intel_pstate.c >+++ linux-pm/drivers/cpufreq/intel_pstate.c >@@ -571,9 +571,10 @@ static inline void update_turbo_state(vo > static int min_perf_pct_min(void) > { > struct cpudata *cpu = all_cpu_data[0]; >+ int turbo_pstate = cpu->pstate.turbo_pstate; > >- return DIV_ROUND_UP(cpu->pstate.min_pstate * 100, >- cpu->pstate.turbo_pstate); >+ return turbo_pstate ? >+ DIV_ROUND_UP(cpu->pstate.min_pstate * 100, turbo_pstate) : 0; > } > > static s16 intel_pstate_get_epb(struct cpudata *cpu_data) > > > Hi, Your patch fixes the issue. Thanks~. Jongman.