From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751172AbdFABsZ (ORCPT ); Wed, 31 May 2017 21:48:25 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:23259 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751082AbdFABsX (ORCPT ); Wed, 31 May 2017 21:48:23 -0400 X-AuditID: b6c32a37-f79f46d000003503-f5-592f72653276 From: Andi Shyti To: Dmitry Torokhov , Jaechul Lee , Beomho Seo Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Andi Shyti , Andi Shyti Subject: [PATCH v2] Input: tm2-touchkey - use LEN_ON as boolean value instead of LED_FULL Date: Thu, 01 Jun 2017 10:47:36 +0900 Message-id: <20170601014736.17808-1-andi.shyti@samsung.com> X-Mailer: git-send-email 2.11.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrPKsWRmVeSWpSXmKPExsWy7bCmnm5qkX6kwburzBbbjzxjtVj84zmT xelP29gtDi96wWjxdn83s8XNT99YLS7vmsPmwO5xfcknZo+ds+6ye/RtWcXo8XmTXABLVKpN RmpiSmqRQmpecn5KZl66rZJ3cLxzvKmZgaGuoaWFuZJCXmJuqq2Si0+ArltmDtAFSgpliTml QKGAxOJiJX07m6L80pJUhYz84hJbpWhDQyM9QwNzPSMjIz0T41grI1OgkoTUjEfvP7MVzOWu WHOTr4HxAmcXIyeHhICJxNEdaxghbDGJC/fWs3UxcnEICexglOh73MQI4XxmlHj0fTIbTMeb Ty1QibWMEksf3WWBcD4ySiw+vw9sFpuApkTT7R9gHSICNRJnL9xnAiliFmhmlPh7oQWsSFgg WuLTsStgRSwCqhIL93xjB7F5BawlnnzrhDpKXmJX20VWkGYJgQNsEq1fXwGt4wByZCU2HWCG qHGRWDdrHtR5whKvjm9hh7ClJBpfPmSC6AVavGHbZSinhVHi98urUB3GEqe6GplAbGYBPol3 X3tYIRbwSnS0CUGUeEjsnTEBKuwoMe+3G0hYSCBWYs6xJ4wTGKUXMDKsYhRLLSjOTU8tNiww 1itOzC0uzUvXS87P3cQITixa5jsYN5zzOcQowMGoxMMrcFEvUog1say4MvcQowQHs5IIr6+a fqQQb0piZVVqUX58UWlOavEhRlNg0ExklhJNzgcmvbySeEMTSwMTMyNgurA0NFQS5xVbfy1C SCA9sSQ1OzW1ILUIpo+Jg1OqgbHSfCGnP+vypW93i8xe0/JXXcvrdZDSHdk1aRON3jD6h679 kpM8te+wN9sXvsP/OFrnbdHvP7zp/1uH4vdM3gqZD/4qhSaabZzh/NfaWCDL4xfvQc/XF5xj RHh/JSrP4GqeVe3ZUHz9c9wu5vRJp/We/zNk6Hu883kty1eZ8zzRq00fczhu8VJiKc5INNRi LipOBACcmH+VQgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrILMWRmVeSWpSXmKPExsVy+t9jQd2UIv1Ig/b1ehbbjzxjtVj84zmT xelP29gtDi96wWjxdn83s8XNT99YLS7vmsPmwO5xfcknZo+ds+6ye/RtWcXo8XmTXABLlJtN RmpiSmqRQmpecn5KZl66rVJoiJuuhZJCXmJuqq1ShK5vSJCSQlliTimQZ2SABhycA9yDlfTt EtwyHr3/zFYwl7tizU2+BsYLnF2MnBwSAiYSbz61MELYYhIX7q1n62Lk4hASWM0o8WfyMyjn I6PEutubmECq2AQ0JZpu/wBKcHCICNRIdJ30B6lhFmhmlGg/cIkNpEZYIFpi1aqrrCA2i4Cq xMI939hBbF4Ba4kn3zqhtslL7Gq7yDqBkXsBI8MqRq7UguLc9NxiowLDTYzA4Nt2WMt/B+OP s9GHGAU4GJV4eAUu6kUKsSaWFVfmHmKU4GBWEuH1VdOPFOJNSaysSi3Kjy8qzUktPsRoCrRy IrOUaHI+MDLySuINTSyNTAzMzAyNDIzNlMR5JwR+iRASSE8sSc1OTS1ILYLpY+LglGpgdFZc P/tkziO/M0pLNZTaSwQfVl2Z/GH51+CwPRwuHe48l2c+5lVIq1Sqav+x2kmlPfbAy4C4ZXo/ bd6dPqKmKHzah+Hg7jA51ayonckhMw++/PmuZ9Y894cZK865nXvwOPFa4X1O78v70vb9y2Cd UXnRefJ6AYZt93LFq/6/n1ldvW6rN++W9UosxRmJhlrMRcWJADtxvtRUAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170601014820epcas1p24563493660adc23d437c55453aa7a655 X-Msg-Generator: CA X-Sender-IP: 182.195.42.79 X-Local-Sender: =?UTF-8?B?7JWI65SUG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLzthLAp?= =?UTF-8?B?G+yCvOyEseyghOyekBtTZW5pb3IgRW5naW5lZXI=?= X-Global-Sender: =?UTF-8?B?QW5kaSBTaHl0aRtUaXplbiBQbGF0Zm9ybSBMYWIuG1NhbXN1?= =?UTF-8?B?bmcgRWxlY3Ryb25pY3MbU2VuaW9yIEVuZ2luZWVy?= X-Sender-Code: =?UTF-8?B?QzEwG1RFTEUbQzEwVjgxMTE=?= CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20170601014820epcas1p24563493660adc23d437c55453aa7a655 X-RootMTR: 20170601014820epcas1p24563493660adc23d437c55453aa7a655 References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit 4e552c8cb5bc ("leds: add LED_ON brightness as boolean value") has introduced the LED_ON enumeration value that can be used instead of LED_FULL which has more of a linear value. Because the tm2-touchscreen doesn't have brightness levels, but it's a simple on/off led, use LED_ON instead of LED_FULL. Signed-off-by: Andi Shyti Reviewed-by: Jaechul Lee Tested-by: Jaechul Lee --- Hi Dmitry, this is the second version of this simple patch sent here: https://marc.info/?l=linux-kernel&m=149062143701658&w=2 no changes, just added Jaechul's review and test. Andi drivers/input/keyboard/tm2-touchkey.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/keyboard/tm2-touchkey.c b/drivers/input/keyboard/tm2-touchkey.c index 485900f953e0..abc266e40e17 100644 --- a/drivers/input/keyboard/tm2-touchkey.c +++ b/drivers/input/keyboard/tm2-touchkey.c @@ -213,7 +213,7 @@ static int tm2_touchkey_probe(struct i2c_client *client, /* led device */ touchkey->led_dev.name = TM2_TOUCHKEY_DEV_NAME; touchkey->led_dev.brightness = LED_FULL; - touchkey->led_dev.max_brightness = LED_FULL; + touchkey->led_dev.max_brightness = LED_ON; touchkey->led_dev.brightness_set = tm2_touchkey_led_brightness_set; error = devm_led_classdev_register(&client->dev, &touchkey->led_dev); -- 2.11.0