From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751323AbdFAFlw (ORCPT ); Thu, 1 Jun 2017 01:41:52 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:57686 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751138AbdFAFlv (ORCPT ); Thu, 1 Jun 2017 01:41:51 -0400 Date: Wed, 31 May 2017 22:41:48 -0700 From: Christoph Hellwig To: John Garry Cc: jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, john.garry2@mail.dcu.ie, linuxarm@huawei.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@arndb.de, Xiang Chen Subject: Re: [PATCH v3 14/23] scsi: hisi_sas: add v3 cq interrupt handler Message-ID: <20170601054147.GB4743@infradead.org> References: <1496241195-217678-1-git-send-email-john.garry@huawei.com> <1496241195-217678-15-git-send-email-john.garry@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1496241195-217678-15-git-send-email-john.garry@huawei.com> User-Agent: Mutt/1.8.0 (2017-02-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > + case SAS_PROTOCOL_SSP: > + { > + unsigned char op = task->ssp_task.cmd->cmnd[0]; > + > + if (op == READ_6 || op == WRITE_6 || > + op == READ_10 || op == WRITE_10 || > + op == READ_12 || op == WRITE_12 || > + op == READ_16 || op == WRITE_16) > + return true; > + break; > + } Wee. why do you care? What about 32-byte CDs or things like Write Same?