From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751365AbdFAGew (ORCPT <rfc822;w@1wt.eu>);
        Thu, 1 Jun 2017 02:34:52 -0400
Received: from verein.lst.de ([213.95.11.211]:44412 "EHLO newverein.lst.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751135AbdFAGev (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 1 Jun 2017 02:34:51 -0400
Date: Thu, 1 Jun 2017 08:34:50 +0200
From: Christoph Hellwig <hch@lst.de>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
        Keith Busch <keith.busch@intel.com>, Hannes Reinecke <hare@suse.de>,
        Max Gurtovoy <maxg@mellanox.com>,
        Linux NVMe Mailinglist <linux-nvme@lists.infradead.org>,
        Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 2/7] nvmet: add uuid field to nvme_ns and populate
        via configfs
Message-ID: <20170601063450.GB16778@lst.de>
References: <cover.1496237370.git.jthumshirn@suse.de> <a82a2dd9214084ef9bb51b541cf609e22e17dd1d.1496237370.git.jthumshirn@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a82a2dd9214084ef9bb51b541cf609e22e17dd1d.1496237370.git.jthumshirn@suse.de>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

This code looks fine, but I'd rather move it past adding CNS 3h support
so that it can add all the uuid-related bits in one go.