From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751142AbdFAMhw (ORCPT <rfc822;w@1wt.eu>);
        Thu, 1 Jun 2017 08:37:52 -0400
Received: from bombadil.infradead.org ([65.50.211.133]:35605 "EHLO
        bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751054AbdFAMhv (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 1 Jun 2017 08:37:51 -0400
Date: Thu, 1 Jun 2017 14:37:45 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Rohit Jain <rohit.k.jain@oracle.com>
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com,
        vincent.guittot@linaro.org, morten.rasmussen@arm.com,
        dietmar.eggemann@arm.com
Subject: Re: [PATCH] sched: Introduce scaled capacity awareness in enqueue
Message-ID: <20170601123745.llebc4ur23d7t4fw@hirez.programming.kicks-ass.net>
References: <1495486094-9097-1-git-send-email-rohit.k.jain@oracle.com>
 <20170530122831.5fyywtplq4jawj3j@hirez.programming.kicks-ass.net>
 <63736e6f-37e6-e287-a920-56ab0d0586b7@oracle.com>
 <20170601122827.5ptc3n47vvk2y7k7@hirez.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170601122827.5ptc3n47vvk2y7k7@hirez.programming.kicks-ass.net>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jun 01, 2017 at 02:28:27PM +0200, Peter Zijlstra wrote:
> On Wed, May 31, 2017 at 03:19:46PM -0700, Rohit Jain wrote:
> 
> > > > 2) This scaled capacity is normalized and mapped into buckets.
> > > Why?
> > 
> > This is done to deterministically define the CPUs which are low on
> > capacities. By mapping it into buckets it becomes easier to do a
> > percentile calculation.
> 
> *sigh*, you're really going to make me read and reverse engineer your
> horrible code.. :/

Blergh, I can't be arsed. It's got horrible style, its stuffed into the
loadavg code even though its completely unrelated to that particular
trainwreck and it adds more global state.

Global state is bad, very bad. And its not at all clear why you'd need
that to begin with.