From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751427AbdFAO6Q (ORCPT ); Thu, 1 Jun 2017 10:58:16 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:30805 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751134AbdFAO6N (ORCPT ); Thu, 1 Jun 2017 10:58:13 -0400 Date: Thu, 1 Jun 2017 17:57:14 +0300 From: Dan Carpenter To: ? ? Cc: "gregkh@linuxfoundation.org" , "linux@roeck-us.net" , "yueyao.zhu@gmail.com" , "devel@driverdev.osuosl.org" , "o_leveque@orange.fr" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/3] staging: typec: Fix one defect of incorrect type in argument. Message-ID: <20170601145714.bjsywgifv2vxaa3o@mwanda> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 01, 2017 at 07:21:00AM +0000, ? ? wrote: > From: Pan Li > > Convert type le16 to cpu of argument 1 in function pd_header_cnt. > > Signed-off-by: Pan Li > --- > drivers/staging/typec/tcpci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/typec/tcpci.c b/drivers/staging/typec/tcpci.c > index df72d8b..405c9cc 100644 > --- a/drivers/staging/typec/tcpci.c > +++ b/drivers/staging/typec/tcpci.c > @@ -287,7 +287,7 @@ static int tcpci_pd_transmit(struct tcpc_dev *tcpc, > unsigned int reg, cnt, header; > int ret; > > - cnt = msg ? pd_header_cnt(msg->header) * 4 : 0; > + cnt = msg ? pd_header_cnt(le16_to_cpu(msg->header)) * 4 : 0; I guess this one is probably correct... regards, dan carpenter