From: "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com>
To: "ericvh@gmail.com" <ericvh@gmail.com>,
"rminnich@sandia.gov" <rminnich@sandia.gov>,
"lucho@ionkov.net" <lucho@ionkov.net>
Cc: "v9fs-developer@lists.sourceforge.net"
<v9fs-developer@lists.sourceforge.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jack@suse.com" <jack@suse.com>,
"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] 9p: set page uptodate when required in write_end()
Date: Fri, 2 Jun 2017 02:31:14 +0000 [thread overview]
Message-ID: <20170602023109.4sr6zz4dgh3e6syn@sasha-lappy> (raw)
In-Reply-To: <20170410184657.13430-1-alexander.levin@verizon.com>
Ping?
On Mon, Apr 10, 2017 at 02:46:57PM -0400, Sasha Levin wrote:
> From: Alexander Levin <alexander.levin@verizon.com>
>
> Commit 77469c3f570 prevented setting the page as uptodate when we wrote the
> right amount of data, fix that.
>
> Fixes: 77469c3f570 ("9p: saner ->write_end() on failing copy into non-uptodate page")
> Reviewed-by: Jan Kara <jack@suse.com>
> Signed-off-by: Alexander Levin <alexander.levin@verizon.com>
> ---
> fs/9p/vfs_addr.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/fs/9p/vfs_addr.c b/fs/9p/vfs_addr.c
> index adaf6f6..e1cbdfd 100644
> --- a/fs/9p/vfs_addr.c
> +++ b/fs/9p/vfs_addr.c
> @@ -310,9 +310,13 @@ static int v9fs_write_end(struct file *filp, struct address_space *mapping,
>
> p9_debug(P9_DEBUG_VFS, "filp %p, mapping %p\n", filp, mapping);
>
> - if (unlikely(copied < len && !PageUptodate(page))) {
> - copied = 0;
> - goto out;
> + if (!PageUptodate(page)) {
> + if (unlikely(copied < len)) {
> + copied = 0;
> + goto out;
> + } else if (len == PAGE_SIZE) {
> + SetPageUptodate(page);
> + }
> }
> /*
> * No need to use i_size_read() here, the i_size
> --
> 2.7.4
--
Thanks,
Sasha
next prev parent reply other threads:[~2017-06-02 2:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-10 18:46 alexander.levin
2017-06-02 2:31 ` Levin, Alexander (Sasha Levin) [this message]
2017-10-11 12:27 ` Levin, Alexander (Sasha Levin)
2017-10-11 16:30 ` Linus Torvalds
2017-10-11 16:46 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170602023109.4sr6zz4dgh3e6syn@sasha-lappy \
--to=alexander.levin@verizon.com \
--cc=ericvh@gmail.com \
--cc=jack@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=rminnich@sandia.gov \
--cc=v9fs-developer@lists.sourceforge.net \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®