From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751180AbdFBOAS (ORCPT <rfc822;w@1wt.eu>);
        Fri, 2 Jun 2017 10:00:18 -0400
Received: from vps0.lunn.ch ([178.209.37.122]:34130 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750971AbdFBOAQ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 2 Jun 2017 10:00:16 -0400
Date: Fri, 2 Jun 2017 16:00:14 +0200
From: Andrew Lunn <andrew@lunn.ch>
To: Colin King <colin.king@canonical.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] net: phy: marvell: make two functions static
Message-ID: <20170602140014.GK12261@lunn.ch>
References: <20170602111424.31287-1-colin.king@canonical.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170602111424.31287-1-colin.king@canonical.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jun 02, 2017 at 12:14:24PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> functions m88e1510_get_temp_critical and m88e1510_get_temp_alarm can be
> made static as they not need to be in global scope.
> 
> Cleans up sparse warnings:
>  "symbol 'm88e1510_get_temp_alarm' was not declared. Should it be static?"
>  "symbol 'm88e1510_get_temp_critical' was not declared. Should it be 
>   static?"

Hi Colin

What about m88e1510_get_temp_alarm()? That should also have a static.

Thanks
     Andrew