From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751553AbdFBWpx (ORCPT ); Fri, 2 Jun 2017 18:45:53 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:58875 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751532AbdFBWpv (ORCPT ); Fri, 2 Jun 2017 18:45:51 -0400 Date: Fri, 2 Jun 2017 15:45:48 -0700 From: Guenter Roeck To: Richard Kuo Cc: linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, Al Viro Subject: Re: hexagon: Use raw_copy_to_user Message-ID: <20170602224548.GA20386@roeck-us.net> References: <1493783568-9887-1-git-send-email-linux@roeck-us.net> <20170602130353.GA11696@roeck-us.net> <20170602213303.GA30438@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170602213303.GA30438@codeaurora.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Richard, On Fri, Jun 02, 2017 at 04:33:04PM -0500, Richard Kuo wrote: > On Fri, Jun 02, 2017 at 06:03:53AM -0700, Guenter Roeck wrote: > > ping .... > > > > On Tue, May 02, 2017 at 08:52:48PM -0700, Guenter Roeck wrote: > > > Commit ac4691fac8ad ("hexagon: switch to RAW_COPY_USER") replaced > > > __copy_to_user_hexagon() with raw_copy_to_user(), but did not catch > > > all callers, resulting in the following build error. > > > > > > arch/hexagon/mm/uaccess.c: In function '__clear_user_hexagon': > > > arch/hexagon/mm/uaccess.c:40:3: error: > > > implicit declaration of function '__copy_to_user_hexagon' > > > > > > Fixes: ac4691fac8ad ("hexagon: switch to RAW_COPY_USER") > > > Cc: Al Viro > > > Signed-off-by: Guenter Roeck > > > Acked-by: Al Viro > > > --- > > > arch/hexagon/mm/uaccess.c | 5 ++--- > > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > > > diff --git a/arch/hexagon/mm/uaccess.c b/arch/hexagon/mm/uaccess.c > > > index ec90afdb3ad0..c599eb126c9e 100644 > > > --- a/arch/hexagon/mm/uaccess.c > > > +++ b/arch/hexagon/mm/uaccess.c > > > @@ -37,15 +37,14 @@ __kernel_size_t __clear_user_hexagon(void __user *dest, unsigned long count) > > > long uncleared; > > > > > > while (count > PAGE_SIZE) { > > > - uncleared = __copy_to_user_hexagon(dest, &empty_zero_page, > > > - PAGE_SIZE); > > > + uncleared = raw_copy_to_user(dest, &empty_zero_page, PAGE_SIZE); > > > if (uncleared) > > > return count - (PAGE_SIZE - uncleared); > > > count -= PAGE_SIZE; > > > dest += PAGE_SIZE; > > > } > > > if (count) > > > - count = __copy_to_user_hexagon(dest, &empty_zero_page, count); > > > + count = raw_copy_to_user(dest, &empty_zero_page, count); > > > > > > return count; > > > } > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-hexagon" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > Acked-by: Richard Kuo > Do you want me to send it to Linus ? Thanks, Guenter