From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751170AbdFCDju (ORCPT ); Fri, 2 Jun 2017 23:39:50 -0400 Received: from omzsmtpe02.verizonbusiness.com ([199.249.25.209]:40538 "EHLO omzsmtpe02.verizonbusiness.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750707AbdFCDjs (ORCPT ); Fri, 2 Jun 2017 23:39:48 -0400 X-IronPort-Anti-Spam-Filtered: false From: "Levin, Alexander (Sasha Levin)" Cc: "mingo@kernel.org" , "paulmck@linux.vnet.ibm.com" , "bigeasy@linutronix.de" , "rostedt@goodmis.org" , "mathieu.desnoyers@efficios.com" , "mhiramat@kernel.org" , "linux-kernel@vger.kernel.org" , "Levin, Alexander (Sasha Levin)" X-IronPort-AV: E=Sophos;i="5.39,287,1493683200"; d="scan'208";a="363802724" To: "peterz@infradead.org" , "tglx@linutronix.de" Subject: [PATCH] perf/tracing/cpuhotplug: don't release cred_guard_mutex if not taken Thread-Topic: [PATCH] perf/tracing/cpuhotplug: don't release cred_guard_mutex if not taken Thread-Index: AQHS3Br48pyU5AkEoUaoA5guleI+nw== Date: Sat, 3 Jun 2017 03:39:13 +0000 Message-ID: <20170603033903.12056-1-alexander.levin@verizon.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.144.60.250] Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v533ds1S023187 From: Alexander Levin If we failed to acquire task's cred_guard_mutex we shouldn't proceed to release it in the error path. Fixes: a63fbed776c ("perf/tracing/cpuhotplug: Fix locking order") Signed-off-by: Alexander Levin --- kernel/events/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/events/core.c b/kernel/events/core.c index 8d6acaeeea17..8e8323c6036b 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -9878,7 +9878,7 @@ SYSCALL_DEFINE5(perf_event_open, if (task) { err = mutex_lock_interruptible(&task->signal->cred_guard_mutex); if (err) - goto err_cred; + goto err_task; /* * Reuse ptrace permission checks for now. -- 2.11.0