From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751194AbdFDXbH (ORCPT ); Sun, 4 Jun 2017 19:31:07 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:52372 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751147AbdFDXbC (ORCPT ); Sun, 4 Jun 2017 19:31:02 -0400 Date: Sun, 04 Jun 2017 19:30:58 -0400 (EDT) Message-Id: <20170604.193058.256838162791393085.davem@davemloft.net> To: jon.mason@broadcom.com Cc: andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com Subject: Re: [PATCH net-next] mdio: mux: make child bus walking more permissive and errors more verbose From: David Miller In-Reply-To: <1496259890-3719-1-git-send-email-jon.mason@broadcom.com> References: <1496259890-3719-1-git-send-email-jon.mason@broadcom.com> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 04 Jun 2017 15:49:23 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jon Mason Date: Wed, 31 May 2017 15:44:50 -0400 > If any errors are encountered while walking the device tree structure of > the MDIO bus for children, the code may silently continue, silently > exit, or throw an error and exit. This make it difficult for device > tree writers to know there is an error. Also, it makes any error in a > child entry of the MDIO bus be fatal for all entries. Instead, we > should provide verbose errors describing the error and then attempt to > continue if it all possible. Also, use of_mdio_parse_addr() > > Signed-off-by: Jon Mason Looks good. Every conversion from break to continue properly gets rid of the child_bus_node release, and this new behavior matches what was discussed a few weeks ago. Applied, thanks.