From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751245AbdFEAB3 (ORCPT ); Sun, 4 Jun 2017 20:01:29 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:52686 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751181AbdFEABV (ORCPT ); Sun, 4 Jun 2017 20:01:21 -0400 Date: Sun, 04 Jun 2017 20:01:19 -0400 (EDT) Message-Id: <20170604.200119.791002119725193988.davem@davemloft.net> To: mhocko@kernel.org Cc: thomas.lendacky@amd.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, mhocko@suse.com Subject: Re: [PATCH] amd-xgbe: use PAGE_ALLOC_COSTLY_ORDER in xgbe_map_rx_buffer From: David Miller In-Reply-To: <20170602155408.12792-1-mhocko@kernel.org> References: <20170602155408.12792-1-mhocko@kernel.org> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 04 Jun 2017 16:19:43 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Michal Hocko Date: Fri, 2 Jun 2017 17:54:08 +0200 > From: Michal Hocko > > xgbe_map_rx_buffer is rather confused about what PAGE_ALLOC_COSTLY_ORDER > means. It uses PAGE_ALLOC_COSTLY_ORDER-1 assuming that > PAGE_ALLOC_COSTLY_ORDER is the first costly order which is not the case > actually because orders larger than that are costly. And even that > applies only to sleeping allocations which is not the case here. We > simply do not perform any costly operations like reclaim or compaction > for those. Simplify the code by dropping the order calculation and use > PAGE_ALLOC_COSTLY_ORDER directly. > > Signed-off-by: Michal Hocko Applied.