From: Joel Fernandes <joelaf@google.com>
To: linux-kernel@vger.kernel.org
Cc: Joel Fernandes <joelaf@google.com>,
kernel-team@android.com, Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>
Subject: [RFC v2 4/4] tracing/ftrace: Add support to record and display tgid
Date: Sat, 3 Jun 2017 21:03:50 -0700 [thread overview]
Message-ID: <20170604040350.12641-5-joelaf@google.com> (raw)
In-Reply-To: <20170604040350.12641-1-joelaf@google.com>
Make function tracer able to record tgid if/when record-tgid is enabled.
Cc: kernel-team@android.com
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Ingo Molnar <mingo@redhat.com>
Signed-off-by: Joel Fernandes <joelaf@google.com>
---
kernel/trace/trace_functions.c | 23 +++++++++++++++++++++--
1 file changed, 21 insertions(+), 2 deletions(-)
diff --git a/kernel/trace/trace_functions.c b/kernel/trace/trace_functions.c
index 05da1e7513f6..290a7a80abf2 100644
--- a/kernel/trace/trace_functions.c
+++ b/kernel/trace/trace_functions.c
@@ -27,6 +27,7 @@ static void
function_stack_trace_call(unsigned long ip, unsigned long parent_ip,
struct ftrace_ops *op, struct pt_regs *pt_regs);
static struct tracer_flags func_flags;
+static bool tgid_recorded;
/* Our option */
enum {
@@ -103,7 +104,8 @@ static int function_trace_init(struct trace_array *tr)
tr->trace_buffer.cpu = get_cpu();
put_cpu();
- tracing_start_taskinfo_record(true, false);
+ tgid_recorded = tr->trace_flags & TRACE_ITER_RECORD_TGID;
+ tracing_start_taskinfo_record(true, tgid_recorded);
tracing_start_function_trace(tr);
return 0;
@@ -112,7 +114,8 @@ static int function_trace_init(struct trace_array *tr)
static void function_trace_reset(struct trace_array *tr)
{
tracing_stop_function_trace(tr);
- tracing_stop_taskinfo_record(true, false);
+ tracing_stop_taskinfo_record(true, tgid_recorded);
+ tgid_recorded = false;
ftrace_reset_array_ops(tr);
}
@@ -253,6 +256,21 @@ func_set_flag(struct trace_array *tr, u32 old_flags, u32 bit, int set)
return 0;
}
+static int
+func_tracer_flag_changed(struct trace_array *tr, unsigned int mask,
+ int enabled)
+{
+ if (mask == TRACE_ITER_RECORD_TGID) {
+ tgid_recorded = !!enabled;
+ if (enabled)
+ tracing_start_taskinfo_record(false, true);
+ else
+ tracing_stop_taskinfo_record(false, true);
+ }
+
+ return 0;
+}
+
static struct tracer function_trace __tracer_data =
{
.name = "function",
@@ -261,6 +279,7 @@ static struct tracer function_trace __tracer_data =
.start = function_trace_start,
.flags = &func_flags,
.set_flag = func_set_flag,
+ .flag_changed = func_tracer_flag_changed,
.allow_instances = true,
#ifdef CONFIG_FTRACE_SELFTEST
.selftest = trace_selftest_startup_function,
--
2.13.0.506.g27d5fe0cd-goog
prev parent reply other threads:[~2017-06-04 4:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-04 4:03 [RFC v2 0/4] tracing: Add support to record and display tgid of tasks Joel Fernandes
2017-06-04 4:03 ` [RFC v2 1/4] tracing: Remove unused declaration of trace_stop_cmdline_recording Joel Fernandes
2017-06-04 4:03 ` [RFC v2 2/4] tracing: Add support for recording tgid of tasks Joel Fernandes
2017-06-04 5:44 ` Joel Fernandes
2017-06-04 4:03 ` [RFC v2 3/4] tracing: Add support for display of tgid in trace output Joel Fernandes
2017-06-04 4:03 ` Joel Fernandes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170604040350.12641-5-joelaf@google.com \
--to=joelaf@google.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome