From: Rakesh Pandit <rakesh@tuxera.com>
To: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>
Cc: <linux-nvme@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
Jens Axboe <axboe@fb.com>, Keith Busch <keith.busch@intel.com>
Subject: Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep for ever
Date: Mon, 5 Jun 2017 13:52:17 +0300 [thread overview]
Message-ID: <20170605105217.GA31313@dhcp-216.srv.tuxera.com> (raw)
In-Reply-To: <20170605081817.GA22122@lst.de>
On Mon, Jun 05, 2017 at 10:18:17AM +0200, Christoph Hellwig wrote:
> On Sun, Jun 04, 2017 at 06:28:15PM +0300, Sagi Grimberg wrote:
> >
> >> I think we need the NVME_CTRL_SCHED_RESET state. In fact I'm pretty
> >> sure some time in the past I already had it in a local tree as a
> >> generalization of rdma and loop already use NVME_CTRL_RESETTING
> >> (they set it before queueing the reset work).
> >
> > I don't remember having it, but I might be wrong...
> >
> > Can you explain again why you think we need it? Sorry for being
> > difficult, but I'm not exactly sure why it makes things better
> > or simpler.
>
> Motly that we can treat a controller as under reset before scheduling
> the reset work, both to prevent multiple schedules, and to make
> checks like the one in nvme_should_reset robus.
>
> But I think something along the lines of the earlier patch from
> Rakesh that just sets the RESETTING state earlier + the cancel_work_sync
> suggested by you should also work for that purpose. So maybe that's
> the way to go after all.
I would post a new patch which includes my RESETTING state earlier
patch + the cancel_work_sync which Sagi suggested after testing.
Sagi: Because my RESETTING patch earlier is subset of your untested
patch with cancel_work_sync, it would be logical to take a signed off
from you as well. May you review/ack/nack the patch? Feel free to
let me know if you want me to change it further or instead you want to
post as author.
I am okay with either as long as we fix the issue.
next prev parent reply other threads:[~2017-06-05 10:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-30 7:16 Rakesh Pandit
2017-05-30 9:36 ` Christoph Hellwig
2017-05-30 10:18 ` Sagi Grimberg
2017-05-30 14:23 ` Rakesh Pandit
2017-06-01 11:43 ` Christoph Hellwig
2017-06-01 12:28 ` Rakesh Pandit
2017-06-01 12:35 ` Christoph Hellwig
2017-06-01 12:36 ` Rakesh Pandit
2017-06-01 12:46 ` Christoph Hellwig
2017-06-01 14:56 ` Ming Lei
2017-06-01 19:33 ` Rakesh Pandit
2017-06-02 1:42 ` Ming Lei
2017-06-04 15:28 ` Sagi Grimberg
2017-06-05 8:18 ` Christoph Hellwig
2017-06-05 10:52 ` Rakesh Pandit [this message]
2017-06-05 11:09 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170605105217.GA31313@dhcp-216.srv.tuxera.com \
--to=rakesh@tuxera.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®