From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] clk: at91: Add sama5d2 suspend/resume
Date: Mon, 5 Jun 2017 16:25:58 +0200 [thread overview]
Message-ID: <20170605142558.7x2eip4o66uj6eby@piout.net> (raw)
In-Reply-To: <20170601074644.GW20170@codeaurora.org>
Hi,
On 01/06/2017 at 00:46:44 -0700, Stephen Boyd wrote:
> > +
> > +static u8 registered_ids[PMC_MAX_IDS];
> > +
> > +void pmc_register_id(u8 id)
> > +{
>
> Shouldn't this also be inside CONFIG_PM? And then
> pmc_register_id() is a nop function when CONFIG_PM=n?
>
I'll do that. I'll rebase on top of clk-next once you fix my silly
mistake.
> > + int i;
> > +
> > + for (i = 0; i < PMC_MAX_IDS; i++) {
> > + if (registered_ids[i] == 0) {
> > + registered_ids[i] = id;
> > + break;
> > + }
> > + if (registered_ids[i] == id)
> > + break;
> > + }
> > +}
>
> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> a Linux Foundation Collaborative Project
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-06-05 14:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-12 14:25 [PATCH v4 1/2] clk: at91: fix clk-generated parenting Alexandre Belloni
2017-05-12 14:25 ` [PATCH v4 2/2] clk: at91: Add sama5d2 suspend/resume Alexandre Belloni
2017-06-01 7:46 ` Stephen Boyd
2017-06-05 14:25 ` Alexandre Belloni [this message]
2017-05-19 1:33 ` [PATCH v4 1/2] clk: at91: fix clk-generated parenting Stephen Boyd
2017-05-30 9:50 ` Alexandre Belloni
2017-06-01 7:47 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170605142558.7x2eip4o66uj6eby@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=boris.brezillon@free-electrons.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®