From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751329AbdFFITA (ORCPT ); Tue, 6 Jun 2017 04:19:00 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:33206 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750755AbdFFIS6 (ORCPT ); Tue, 6 Jun 2017 04:18:58 -0400 Date: Tue, 6 Jun 2017 10:18:51 +0200 From: Peter Zijlstra To: Thomas Gleixner Cc: mingo@kernel.org, rostedt@goodmis.org, bigeasy@linutronix.de, linux-kernel@vger.kernel.org Subject: Re: [RFC][PATCH 1/3] rt_mutex: Add lockdep annotations Message-ID: <20170606081851.6yonfnsxsgrah4n5@hirez.programming.kicks-ass.net> References: <20170531151612.797882111@infradead.org> <20170531152019.612196435@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 04, 2017 at 04:26:43PM +0200, Thomas Gleixner wrote: > On Wed, 31 May 2017, Peter Zijlstra wrote: > > > Now that (PI) futexes have their own private RT-mutex interface and > > implementation we can easily add lockdep annotations to the existing > > RT-mutex interface. > > > > Signed-off-by: Peter Zijlstra (Intel) > > --- > > include/linux/rtmutex.h | 25 +++++++++++++++++++++---- > > kernel/locking/rtmutex-debug.c | 6 +++++- > > Shouldn't we get rid of all that home brewn rtmutex debug muck? mutex also still has its mutex-debug.* stuff. It validates a little more state. Also, and I think this is the main benefit, it has the magic bits in that detect corruption without the full space/time costs of lockdep. Maybe we can trim the rtmutex-debug a wee bit, but then futexes don't get that coverage. I'll put looking at this on the todo list.