From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751471AbdFFLat (ORCPT ); Tue, 6 Jun 2017 07:30:49 -0400 Received: from www.llwyncelyn.cymru ([82.70.14.225]:57740 "EHLO fuzix.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751389AbdFFLas (ORCPT ); Tue, 6 Jun 2017 07:30:48 -0400 Date: Tue, 6 Jun 2017 12:29:46 +0100 From: Alan Cox To: Johan Hovold Cc: Greg Kroah-Hartman , Jiri Slaby , Tony Luck , Fenghua Yu , Samuel Ortiz , "David S. Miller" , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH 0/9] tty: drop broken alt-speed handling Message-ID: <20170606122946.13d63430@lxorguk.ukuu.org.uk> In-Reply-To: <20170606105441.689-1-johan@kernel.org> References: <20170606105441.689-1-johan@kernel.org> Organization: Intel Corporation X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 6 Jun 2017 12:54:32 +0200 Johan Hovold wrote: > Setting an alt-speed using TIOCSSERIAL and SPD flags has been deprecated > since v2.1.69 and has been broken for all tty drivers but serial-core > since v3.10 and commit 6865ff222cca ("TTY: do not warn about setting > speed via SPD_*") without anyone noticing (for four years). We have the ability to set the speed directly via termios so I doubt anyone is using the remaining hacks either but I guess someone may. All looks good to me. Reviewed-by: Alan Cox Alan