From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751577AbdFFQzj (ORCPT ); Tue, 6 Jun 2017 12:55:39 -0400 Received: from mail.skyhub.de ([5.9.137.197]:33422 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751445AbdFFQzh (ORCPT ); Tue, 6 Jun 2017 12:55:37 -0400 Date: Tue, 6 Jun 2017 18:55:18 +0200 From: Borislav Petkov To: Chris Packham Cc: "linux-edac@vger.kernel.org" , "mchehab@kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] EDAC: mv64x60 calculate memory size correctly Message-ID: <20170606165518.2hitef2pbjavjww4@pd.tnic> References: <20170606024136.22613-1-chris.packham@alliedtelesis.co.nz> <33f892b086ec4d638ed5c955bec68303@svr-chch-ex1.atlnz.lc> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <33f892b086ec4d638ed5c955bec68303@svr-chch-ex1.atlnz.lc> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 06, 2017 at 03:07:04AM +0000, Chris Packham wrote: > I'll wait for feedback before sending a v2. You can't be expecting me to review PPC code reliably. :-) AFAIR from the recent discussion, Michael said that the aim is to remove CONFIG_MV64X60 and since this driver depends on it, that would make it obsolete too. But I don't think we've ever "hijacked" a driver and renamed it to be used as a driver on a different architecture - that would be just too unorthodox. So if I had to decide, I'd suggest you create your own armada_edac.c or whatever that is and put your code there. Or, if you're going to support multiple Marvell chips, then call it mv_edac.c or marvell_edac.c or so and start building a fine driver there. How does that sound? -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.