From: David Miller <davem@davemloft.net>
To: vivien.didelot@savoirfairelinux.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@savoirfairelinux.com, f.fainelli@gmail.com,
andrew@lunn.ch
Subject: Re: [PATCH net-next 3/5] net: dsa: add CPU and DSA ports as VLAN members
Date: Wed, 07 Jun 2017 15:00:34 -0400 (EDT) [thread overview]
Message-ID: <20170607.150034.106912047540062374.davem@davemloft.net> (raw)
In-Reply-To: <20170606205631.22880-4-vivien.didelot@savoirfairelinux.com>
From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Date: Tue, 6 Jun 2017 16:56:29 -0400
> @@ -166,6 +166,9 @@ static int dsa_switch_vlan_add(struct dsa_switch *ds,
> bitmap_zero(members, ds->num_ports);
> if (ds->index == info->sw_index)
> set_bit(info->port, members);
> + for (port = 0; port < ds->num_ports; ++port)
> + if (dsa_is_cpu_port(ds, port) || dsa_is_dsa_port(ds, port))
> + set_bit(port, members);
Please use the more canonical "x++" post-increment in the for() statement.
Thank you.
next prev parent reply other threads:[~2017-06-07 19:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-06 20:56 [PATCH net-next 0/5] net: dsa: add cross-chip VLAN support Vivien Didelot
2017-06-06 20:56 ` [PATCH net-next 1/5] net: dsa: mv88e6xxx: define membership on VLAN add Vivien Didelot
2017-06-07 19:31 ` Florian Fainelli
2017-06-06 20:56 ` [PATCH net-next 2/5] net: dsa: check VLAN capability of every switch Vivien Didelot
2017-06-07 19:39 ` Florian Fainelli
2017-06-07 20:03 ` Vivien Didelot
2017-06-06 20:56 ` [PATCH net-next 3/5] net: dsa: add CPU and DSA ports as VLAN members Vivien Didelot
2017-06-07 19:00 ` David Miller [this message]
2017-06-07 19:38 ` Florian Fainelli
2017-06-06 20:56 ` [PATCH net-next 4/5] net: dsa: mv88e6xxx: exclude all ports in new VLAN Vivien Didelot
2017-06-07 19:34 ` Florian Fainelli
2017-06-06 20:56 ` [PATCH net-next 5/5] net: dsa: mv88e6xxx: do not purge a VTU entry Vivien Didelot
2017-06-07 19:37 ` Florian Fainelli
2017-06-07 19:59 ` Vivien Didelot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170607.150034.106912047540062374.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®