mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	"Rik van Riel" <riel@redhat.com>,
	James Hartsock <hartsjc@redhat.com>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>,
	Tim Wright <tim@binbash.co.uk>, Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH 2/2] tick: Make sure tick timer is active when bypassing reprogramming
Date: Wed, 7 Jun 2017 04:17:41 +0000	[thread overview]
Message-ID: <20170607040801.4r7iqfzynf3d3xom@sasha-lappy> (raw)
In-Reply-To: <20170606145227.GB22016@lerouge>

[-- Attachment #1: Type: text/plain, Size: 2361 bytes --]

On Tue, Jun 06, 2017 at 04:52:29PM +0200, Frederic Weisbecker wrote:
> On Sat, Jun 03, 2017 at 01:00:53PM +0000, Levin, Alexander (Sasha Levin) wrote:
> > On Sat, Jun 03, 2017 at 02:42:43PM +0200, Frederic Weisbecker wrote:
> > > On Sat, Jun 03, 2017 at 08:06:41AM +0000, Levin, Alexander (Sasha Levin) wrote:
> > > > On Fri, Apr 21, 2017 at 04:00:55PM +0200, Frederic Weisbecker wrote:
> > > > > diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
> > > > > index 502b320..be7ca4d 100644
> > > > > --- a/kernel/time/tick-sched.c
> > > > > +++ b/kernel/time/tick-sched.c
> > > > > @@ -783,8 +783,13 @@ static ktime_t tick_nohz_stop_sched_tick(struct tick_sched *ts,
> > > > >  	tick = expires;
> > > > >  
> > > > >  	/* Skip reprogram of event if its not changed */
> > > > > -	if (ts->tick_stopped && (expires == ts->next_tick))
> > > > > -		goto out;
> > > > > +	if (ts->tick_stopped && (expires == ts->next_tick)) {
> > > > > +		/* Sanity check: make sure clockevent is actually programmed */
> > > > > +		if (likely(dev->next_event <= ts->next_tick))
> > > > > +			goto out;
> > > > > +
> > > > > +		WARN_ON_ONCE(1);
> > > > > +	}
> > > > 
> > > > I seem to be hitting that in a KVM vm, even without load (sometimes
> > > > right after boot):
> > > 
> > > Ah, can you tell me which tree you were using? Is it tip/master?
> > 
> > Its next-20170601: https://urldefense.proofpoint.com/v2/url?u=https-3A__git.kernel.org_pub_scm_linux_kernel_git_next_linux-2Dnext.git_commit_-3Fh-3Dnext-2D20170601-26id-3D3ab334ebe84e0dfd1cc3ea2fe77f5ce4406f7370&d=DwIBAg&c=udBTRvFvXC5Dhqg7UHpJlPps3mZ3LRxpb6__0PomBTQ&r=bUtaaC9mlBij4OjEG_D-KMy3t3Ka3bY06suGz7ewY7g&m=0ex_DoQxODGZtsXpFBMXf2fPbFxv2ogjY9fVReKqbpk&s=t0F0_37WnCEpxAZR6WD3d_Q4n0Lp_2HCNOx3b_iOGtI&e= 
> > 
> > > Can you give me its HEAD and your config file?
> > 
> > Attached config.
> 
> Thanks Sasha!
> 
> I couldn't reproduce it, that config boots fine on my kvm.
> Would you have the time to dump some traces for me?
> 
> I'd need you to add this boot option: trace_event=hrtimer_cancel,hrtimer_start,hrtimer_expire_entry
> And boot your kernel with the below patch. This will dump the timer traces to your console.
> I would be very interested in the resulting console dump file.

Attached. Let me know if you need anything else.

-- 

Thanks,
Sasha

[-- Attachment #2: log.txt.gz --]
[-- Type: application/gzip, Size: 32672 bytes --]

  reply	other threads:[~2017-06-07  4:18 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-21 14:00 [PATCH 0/2] nohz: Deal with clock reprogram skipping issues v2 Frederic Weisbecker
2017-04-21 14:00 ` [PATCH 1/2] nohz: Fix again collision between tick and other hrtimers Frederic Weisbecker
2017-04-23 11:36   ` [tip:timers/urgent] " tip-bot for Frederic Weisbecker
2017-05-17  8:46   ` [tip:timers/nohz] nohz: Fix collision between tick and other hrtimers, again tip-bot for Frederic Weisbecker
2017-04-21 14:00 ` [PATCH 2/2] tick: Make sure tick timer is active when bypassing reprogramming Frederic Weisbecker
2017-04-23 11:37   ` [tip:timers/urgent] " tip-bot for Frederic Weisbecker
2017-06-03  8:06   ` [PATCH 2/2] " Levin, Alexander (Sasha Levin)
2017-06-03 12:42     ` Frederic Weisbecker
2017-06-03 13:00       ` Levin, Alexander (Sasha Levin)
2017-06-06 14:52         ` Frederic Weisbecker
2017-06-07  4:17           ` Levin, Alexander (Sasha Levin) [this message]
2017-06-07 14:14             ` Frederic Weisbecker
2017-06-07 21:36               ` Levin, Alexander (Sasha Levin)
2017-06-08 19:07                 ` [PATCH] nohz: Fix spurious warning when hrtimer and clockevent get out of sync Frederic Weisbecker
2017-06-08 22:13                   ` Levin, Alexander (Sasha Levin)
2017-06-09  0:48                     ` Frederic Weisbecker
2017-06-09 12:13                       ` Levin, Alexander (Sasha Levin)
2017-06-09 12:26                         ` Peter Zijlstra
2017-06-09 13:06                         ` Frederic Weisbecker
2017-04-24  8:08 ` [PATCH 0/2] nohz: Deal with clock reprogram skipping issues v2 Ingo Molnar
2017-04-24 14:04   ` Frederic Weisbecker
2017-04-24 14:45     ` Ingo Molnar
2017-04-26 14:55       ` Frederic Weisbecker
2017-04-26 18:49         ` Ingo Molnar
2017-04-26 21:07           ` Frederic Weisbecker
2017-04-24 17:01     ` [tip:timers/urgent] nohz: Print more debug info in tick_nohz_stop_sched_tick() tip-bot for Frederic Weisbecker
  -- strict thread matches above, loose matches on Subject: below --
2017-04-20 15:30 [PATCH 0/2] nohz: Deal with clock reprogram skipping issues Frederic Weisbecker
2017-04-20 15:30 ` [PATCH 2/2] tick: Make sure tick timer is active when bypassing reprogramming Frederic Weisbecker
2017-04-20 16:01   ` Rik van Riel
2017-04-20 17:56   ` Thomas Gleixner
2017-04-20 18:29     ` Frederic Weisbecker
2017-04-20 19:40       ` Thomas Gleixner
2017-04-20 23:27         ` Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170607040801.4r7iqfzynf3d3xom@sasha-lappy \
    --to=alexander.levin@verizon.com \
    --cc=fweisbec@gmail.com \
    --cc=hartsjc@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=pavel@ucw.cz \
    --cc=peterz@infradead.org \
    --cc=riel@redhat.com \
    --cc=stable@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=tim@binbash.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®