From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751571AbdFGJeb (ORCPT ); Wed, 7 Jun 2017 05:34:31 -0400 Received: from pandora.armlinux.org.uk ([78.32.30.218]:37542 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751203AbdFGJe3 (ORCPT ); Wed, 7 Jun 2017 05:34:29 -0400 Date: Wed, 7 Jun 2017 10:33:50 +0100 From: Russell King - ARM Linux To: Yisheng Xie Cc: nico@linaro.org, catalin.marinas@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk, wangfangpeng1@huawei.com, guohanjun@huawei.com, matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] Revert "ARM: 8433/1: add a VMSPLIT_3G_OPT config option" Message-ID: <20170607093350.GJ4902@n2100.armlinux.org.uk> References: <1496825972-26829-1-git-send-email-xieyisheng1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1496825972-26829-1-git-send-email-xieyisheng1@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 07, 2017 at 04:59:32PM +0800, Yisheng Xie wrote: > This reverts commit 63ce446c9b5787a94ed875bab20772e1a2b3092f. There's no real reason to revert this, thereby removing it from non-LPAE cases where it does work. You've already shown adding a dependency for LPAE on this option (or even vice versa) is enough to stop the problem occuring. IMHO, It would be better to make VMSPLIT_3G_OPT depend on !ARM_LPAE. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.