From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751597AbdFGN76 (ORCPT ); Wed, 7 Jun 2017 09:59:58 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:59705 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751489AbdFGN74 (ORCPT ); Wed, 7 Jun 2017 09:59:56 -0400 Date: Wed, 7 Jun 2017 06:59:52 -0700 From: Christoph Hellwig To: Greg KH Cc: David Kershner , corbet@lwn.net, tglx@linutronix.de, mingo@kernel.org, akpm@linux-foundation.org, jes.sorensen@gmail.com, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, driverdev-devel@linuxdriverproject.org, sparmaintainer@unisys.com Subject: Re: [PATCH 0/3] move visorbus out of staging to drivers/virt/visorbus Message-ID: <20170607135952.GB20110@infradead.org> References: <1496693252-4349-1-git-send-email-david.kershner@unisys.com> <20170606144909.GA31938@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170606144909.GA31938@kroah.com> User-Agent: Mutt/1.8.0 (2017-02-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 06, 2017 at 04:49:09PM +0200, Greg KH wrote: > On Mon, Jun 05, 2017 at 04:07:29PM -0400, David Kershner wrote: > > This patchset moves drivers/staging/unisys/include to > > include/linux/visorbus, and moves drivers/staging/unisys/visorbus to > > drivers/virt/visorbus. > > Um, are you thinking it is ready to be moved? Have you asked for > another review? > > In a totally random chance, I was doing some driver core work today and > I noticed that in drivers/staging/unisys/visorbus/visorbus_main.c, you > have 2 tabs for your 'struct attribute' variables, which is really odd. That's the least of the problems. Just about any function in there is doing functionally stupid things. E.g. raw sg_phys() calls for I/O instead of dma mapping routines or parsing SCSI INQUIRY data in the driver.