mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Jiri Olsa <jolsa@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
	kernel-team@lge.com, David Ahern <dsahern@gmail.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Wang Nan <wangnan0@huawei.com>
Subject: [PATCH v3 3/6] perf tools: Decompress kernel module when reading DSO data
Date: Thu,  8 Jun 2017 00:39:00 +0900	[thread overview]
Message-ID: <20170607153903.1114-4-namhyung@kernel.org> (raw)
In-Reply-To: <20170607153903.1114-1-namhyung@kernel.org>

Currently perf decompresses kernel modules when loading symbol table but
it missed to do it when reading raw data.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
 tools/perf/util/dso.c | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)

diff --git a/tools/perf/util/dso.c b/tools/perf/util/dso.c
index 59257ce4580e..2a0c689227f8 100644
--- a/tools/perf/util/dso.c
+++ b/tools/perf/util/dso.c
@@ -463,8 +463,22 @@ static int __open_dso(struct dso *dso, struct machine *machine)
 		return -EINVAL;
 	}
 
-	if (!is_regular_file(name))
+	if (!is_regular_file(name)) {
+		free(name);
 		return -EINVAL;
+	}
+
+	if (dso__needs_decompress(dso)) {
+		char newpath[KMOD_DECOMP_LEN];
+		size_t len = sizeof(newpath);
+
+		if (dso__decompress_kmodule_path(dso, name, newpath, len) < 0) {
+			free(name);
+			return -1;
+		}
+
+		strcpy(name, newpath);
+	}
 
 	fd = do_open(name);
 	free(name);
-- 
2.13.0

  parent reply	other threads:[~2017-06-07 15:39 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-07 15:38 [PATCHSET v3 0/6] perf tools: Fix for Compressed kernel modules Namhyung Kim
2017-06-07 15:38 ` [PATCH v3 1/6] perf tools: Introduce dso__decompress_kmodule_{fd,path} Namhyung Kim
2017-06-07 15:38 ` [PATCH v3 2/6] perf annotate: Use dso__decompress_kmodule_path() Namhyung Kim
2017-06-07 15:39 ` Namhyung Kim [this message]
2017-06-07 22:23   ` [PATCH v3 3/6] perf tools: Decompress kernel module when reading DSO data Arnaldo Carvalho de Melo
2017-06-07 23:53     ` Namhyung Kim
2017-06-07 15:39 ` [PATCH v3 4/6] perf test: Decompress kernel module before objdump Namhyung Kim
2017-06-07 22:25   ` Arnaldo Carvalho de Melo
2017-06-07 23:57     ` Namhyung Kim
2017-06-08  0:37     ` Namhyung Kim
2017-06-07 15:39 ` [PATCH v3 5/6] perf symbols: Keep DSO->symtab_type after decompress Namhyung Kim
2017-06-07 15:39 ` [PATCH v3 6/6] perf symbols: Kill dso__build_id_is_kmod() Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170607153903.1114-4-namhyung@kernel.org \
    --to=namhyung@kernel.org \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=dsahern@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kernel-team@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=wangnan0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome