From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751911AbdFGVzh (ORCPT ); Wed, 7 Jun 2017 17:55:37 -0400 Received: from gate2.alliedtelesis.co.nz ([202.36.163.20]:52788 "EHLO gate2.alliedtelesis.co.nz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751744AbdFGVzf (ORCPT ); Wed, 7 Jun 2017 17:55:35 -0400 From: Chris Packham To: bp@alien8.de, linux-edac@vger.kernel.org Cc: Chris Packham , Mauro Carvalho Chehab , linux-kernel@vger.kernel.org Subject: [PATCH] EDAC: mv64x60: sanity check edac_op_state before registering Date: Thu, 8 Jun 2017 09:55:30 +1200 Message-Id: <20170607215530.8604-1-chris.packham@alliedtelesis.co.nz> X-Mailer: git-send-email 2.13.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org edac_op_state is a module parameter which affects the behaviour of the driver probe which can potentially be invoked as soon as the platform driver registration happens. Because of this we need to ensure that we sanity check the module parameter before calling platform_register_drivers(). Signed-off-by: Chris Packham --- drivers/edac/mv64x60_edac.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/edac/mv64x60_edac.c b/drivers/edac/mv64x60_edac.c index c83d02a52fd6..9b18a0a606b7 100644 --- a/drivers/edac/mv64x60_edac.c +++ b/drivers/edac/mv64x60_edac.c @@ -867,11 +867,6 @@ static struct platform_driver * const drivers[] = { static int __init mv64x60_edac_init(void) { - int ret; - - ret = platform_register_drivers(drivers, ARRAY_SIZE(drivers)); - if (ret) - return ret; printk(KERN_INFO "Marvell MV64x60 EDAC driver " MV64x60_REVISION "\n"); printk(KERN_INFO "\t(C) 2006-2007 MontaVista Software\n"); @@ -885,7 +880,7 @@ static int __init mv64x60_edac_init(void) break; } - return 0; + return platform_register_drivers(drivers, ARRAY_SIZE(drivers)); } module_init(mv64x60_edac_init); -- 2.13.0