From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Philipp Zabel <philipp.zabel@gmail.com>
Cc: linux-input@vger.kernel.org, Jiri Kosina <jikos@kernel.org>,
linux-usb <linux-usb@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] HID: usbhid: Add HID_QUIRK_NO_INIT_REPORTS for Oculus Rift CV1
Date: Thu, 8 Jun 2017 09:29:22 +0200 [thread overview]
Message-ID: <20170608072922.GJ16591@mail.corp.redhat.com> (raw)
In-Reply-To: <CA+gwMccJqUfKdnyQfyaMWvBBY5rdZS_cmfy_j+Xem5KwX4PXKA@mail.gmail.com>
On Jun 08 2017 or thereabouts, Philipp Zabel wrote:
> Hi Benjamin,
>
> On Wed, Jun 7, 2017 at 9:11 AM, Benjamin Tissoires
> <benjamin.tissoires@redhat.com> wrote:
> > Hi Philip,
> >
> > On Jun 07 2017 or thereabouts, Philipp Zabel wrote:
> [...]
> > 2 things:
> > - the 2 patches should be squashed together. There is no point having a
> > single patch for just 2 defines not used anywhere else.
> > - I believe you don't even need this quirk in the development version of
> > the hid tree. Would you mind trying a plain v4.12-rcX and report if
> > you still need the quirk?
>
> Thanks, you are right. I just checked on v4.12-rc4 and now it works without
> the quirk. Sorry for the noise.
No worries. It's always interesting to know that we introduced a patch
that actually fixes hardware :)
So thanks for the report and the attempt :)
Cheers,
Benjamin
prev parent reply other threads:[~2017-06-08 7:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-07 5:54 [PATCH 1/2] HID: Add Oculus Rift CV1 id Philipp Zabel
2017-06-07 5:54 ` [PATCH 2/2] HID: usbhid: Add HID_QUIRK_NO_INIT_REPORTS for Oculus Rift CV1 Philipp Zabel
2017-06-07 7:11 ` Benjamin Tissoires
2017-06-08 7:22 ` Philipp Zabel
2017-06-08 7:29 ` Benjamin Tissoires [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170608072922.GJ16591@mail.corp.redhat.com \
--to=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=philipp.zabel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome