From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751910AbdFHI44 (ORCPT ); Thu, 8 Jun 2017 04:56:56 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:64705 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751475AbdFHI4z (ORCPT ); Thu, 8 Jun 2017 04:56:55 -0400 From: Arnd Bergmann To: Thomas Gleixner Cc: Peter Zijlstra , Arnd Bergmann , Ingo Molnar , Sebastian Andrzej Siewior , Anna-Maria Gleixner , Boris Ostrovsky , linux-kernel@vger.kernel.org Subject: [PATCH] cpu/hotplug: remove unused check_for_tasks() function Date: Thu, 8 Jun 2017 10:55:33 +0200 Message-Id: <20170608085544.2257132-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:9xqkXGsIjZUlStKZFhTPjkKe8zKoZ1nSRK9INihqJD5PidUa1kV knvDwAE4rV5O46tg3+8+fwyZpwjYKs6y50k0/Abd7aILXw2QSFWSR2Rx7tDy8XNDeej/+HC wuKzGVqiW52eWmAWVWXr9R+XNqClbWvK/RfC9TiQ8bgoVVIcT5KvkKz3dD8x0HmJjmVM7tj kbYA2z3QPc3ATKDoSnhGA== X-UI-Out-Filterresults: notjunk:1;V01:K0:XSU6DaBm0I4=:G7csVx3veybOw7N8DyMWi6 yJr0C++ps0MZy3/B0j6hbTcgCrI+xgTCTexpn+jFZeNG6PQvw459kVEUZIkrJfqr1BAMb6htR mZgNEivVPNdU8e2DzbXaB67hG0M5Uy4oix/vk6h99Xnw0NlRcfu4DidpHLmWSapjgICKpLmO8 7Uh5Cra4b9lUhFnyx4EqoJRsxd09jZ1MnhzIzBVe/+d6ogxh5vf5tySy06PPshI1WMKUCzFMK dg5NtVm3RhzbnDvv6+UhPNm4AZ8j+ebuDW3R09rtSpR41mo3zeXmJmENguDreZEEQC8im7QmU vY1bcm82QwZIJWQ8P+yR4HsxmUXEDvV7auyy8EAuDmUAxABFUXWR4CRp+l06PazNh7KoSQNLk WbSbPPzTHSea3iN10ovMb6coKfGgLJ4/bI6KpL+NNdxqCALdY0tLJnCTyPAIbn17zGToDCay5 1xHggvSbUJFwvwH/tkPtoIbl6rOCZ3xkqubqqnl+8LYLxBnG3XjIQnnAZKNR92lqRjrWAAP/F 65hsJvBLBOnNXiLUvGx5pA+wvqIsa6D9UVg4vC3uWUMONUFSp7QMkEP2tckQNDQh0GNrjHeT3 +MVilK6MGrRcFMJlrJhhnIVx/SZmly9Cvy0nPAO3RzqhUlOwFAP+qtRNXZEx0VFhjFdVTrGkH ihC5S5BbBhN7ofGJavEuZcduxsN357yzzlDvBUnkozs65tZuNu8a0VRU1t7uHw5nv/Uw= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org clang -Wunused-function found one remaining function that was apparently meant to be removed in a recent code cleanup: kernel/cpu.c:565:20: warning: unused function 'check_for_tasks' [-Wunused-function] Fixes: 530e9b76ae8f ("cpu/hotplug: Remove obsolete cpu hotplug register/unregister functions") Signed-off-by: Arnd Bergmann --- kernel/cpu.c | 24 ------------------------ 1 file changed, 24 deletions(-) diff --git a/kernel/cpu.c b/kernel/cpu.c index 7435ffc6163b..d0f5f54aa087 100644 --- a/kernel/cpu.c +++ b/kernel/cpu.c @@ -562,30 +562,6 @@ void clear_tasks_mm_cpumask(int cpu) rcu_read_unlock(); } -static inline void check_for_tasks(int dead_cpu) -{ - struct task_struct *g, *p; - - read_lock(&tasklist_lock); - for_each_process_thread(g, p) { - if (!p->on_rq) - continue; - /* - * We do the check with unlocked task_rq(p)->lock. - * Order the reading to do not warn about a task, - * which was running on this cpu in the past, and - * it's just been woken on another cpu. - */ - rmb(); - if (task_cpu(p) != dead_cpu) - continue; - - pr_warn("Task %s (pid=%d) is on cpu %d (state=%ld, flags=%x)\n", - p->comm, task_pid_nr(p), dead_cpu, p->state, p->flags); - } - read_unlock(&tasklist_lock); -} - /* Take this CPU down. */ static int take_cpu_down(void *_param) { -- 2.9.0