mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: tytso@mit.edu, linux-kernel@vger.kernel.org,
	kernel-hardening@lists.openwall.com
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>
Subject: [PATCH] random: default the warning to be on
Date: Fri,  9 Jun 2017 03:03:36 +0200	[thread overview]
Message-ID: <20170609010336.28981-1-Jason@zx2c4.com> (raw)

This commit is meant to be rebase-fixup'd into the one entitled: "random: warn
when kernel uses unseeded randomness" if you so desire.

I originally had planned to do things this way -- have it default on for
all users, not just debug users. But when I saw all the log spam, I
decided maybe it should, much to my dismay, be a debug-only feature.
However, you very nicely solved the log spam issue by preventing
same-source consecutive warnings, which makes the situation much more
manageable. Thus, in order to tease out the weird obscure cases of
unseeded randomness on unlikely platforms, this commit turns it on
everywhere.

It's fairly non-invasive now, and it will help us get some visibility into
the issue that we otherwise wouldn't have.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
---
 lib/Kconfig.debug | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index c4159605bfbf..fd5e67bcd46c 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -1212,7 +1212,6 @@ config STACKTRACE
 config WARN_UNSEEDED_RANDOM
 	bool "Warn when kernel uses unseeded randomness"
 	default y
-	depends on DEBUG_KERNEL
 	help
 	  Some parts of the kernel contain bugs relating to their use of
 	  cryptographically secure random numbers before it's actually possible
-- 
2.13.1

                 reply	other threads:[~2017-06-09  1:03 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170609010336.28981-1-Jason@zx2c4.com \
    --to=jason@zx2c4.com \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®