From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751992AbdFINwX (ORCPT ); Fri, 9 Jun 2017 09:52:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:45304 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751848AbdFINwU (ORCPT ); Fri, 9 Jun 2017 09:52:20 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8975823966 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Fri, 9 Jun 2017 09:52:10 -0400 From: Steven Rostedt To: "Paul E. McKenney" Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, jiangshanlai@gmail.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org, dhowells@redhat.com, edumazet@google.com, fweisbec@gmail.com, oleg@redhat.com, bobby.prani@gmail.com Subject: Re: [PATCH tip/core/rcu 0/88] Commits for 4.13 Message-ID: <20170609095210.65c1dfe7@gandalf.local.home> In-Reply-To: <20170525215934.GA11578@linux.vnet.ibm.com> References: <20170525215934.GA11578@linux.vnet.ibm.com> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 25 May 2017 14:59:34 -0700 "Paul E. McKenney" wrote: > Hello! > > This rather long series mostly removes unused features, shrinks the > include/linux/rcupdate.h file's .i intermediate-output size, updates > rcutorture testing, and supplies miscellaneous fixes. Branching proved > impractical due to the large footprint of many of the commits, hence the > long linear series. On the other hand, this series's diffstat summary > line is as follows: > > 87 files changed, 1745 insertions(+), 4389 deletions(-) > Hi Paul, 88 patches is quite overwhelming. I would recommend breaking something like this up into multiple patch series with different topics. One could be the ones that affect seftests only. Another for srcu, another for documentation, etc. When one gets 88 patches and sees that it's a hodge podge of various parts of RCU, they tend to just ignore the entire series. If you want reviewers, I strongly recommend breaking it down nicer so that those that are interested in only parts of RCU will be more likely to review the patches. Otherwise, people will just say "I don't have time to sort through all this to find what I'm interested in reviewing", and skip the entire series. Thanks! -- Steve