From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751825AbdFILrT (ORCPT ); Fri, 9 Jun 2017 07:47:19 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:52659 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751530AbdFILrS (ORCPT ); Fri, 9 Jun 2017 07:47:18 -0400 Date: Fri, 9 Jun 2017 13:47:14 +0200 From: Sebastian Reichel To: Arnd Bergmann Cc: Kishon Vijay Abraham I , Tony Lindgren , Rob Herring , linux-kernel@vger.kernel.org Subject: Re: [PATCH] phy: cpcap-usb: add MUSB dependency Message-ID: <20170609114714.ysbbd4y4zqxt6tzx@earth> References: <20170609101655.2730560-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="gtr253shthtd5mif" Content-Disposition: inline In-Reply-To: <20170609101655.2730560-1-arnd@arndb.de> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --gtr253shthtd5mif Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri, Jun 09, 2017 at 12:16:40PM +0200, Arnd Bergmann wrote: > When MUSB is a loadable module, we get a link error for a built-in > CPCAP driver: >=20 > drivers/phy/built-in.o: In function `cpcap_usb_phy_remove': > phy-cpcap-usb.c:(.text+0xed9): undefined reference to `musb_mailbox' >=20 > This adds a Kconfig dependency to prevent this broken configuration, > enforcing that CPCAP can only be a module when MUSB is also a module. >=20 > Fixes: 68a1f7c9d470 ("phy: cpcap-usb: Add CPCAP PMIC USB support") > Signed-off-by: Arnd Bergmann Reviewed-by: Sebastian Reichel -- Sebastian > --- > drivers/phy/motorola/Kconfig | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/phy/motorola/Kconfig b/drivers/phy/motorola/Kconfig > index 91a46cffd639..6bb7d6bdf1bf 100644 > --- a/drivers/phy/motorola/Kconfig > +++ b/drivers/phy/motorola/Kconfig > @@ -4,6 +4,7 @@ > config PHY_CPCAP_USB > tristate "CPCAP PMIC USB PHY driver" > depends on USB_SUPPORT && IIO > + depends on USB_MUSB_HDRC || USB_MUSB_HDRC=3Dn > select GENERIC_PHY > select USB_PHY > help > --=20 > 2.9.0 >=20 --gtr253shthtd5mif Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAlk6ir0ACgkQ2O7X88g7 +ppQUhAAqLrSR/9wg4IER+ZGF/hUVSlj752aOVOvjsOr8EQdROlx3JAFU5D13eTH jSRqg2j3v1oESyrnZS4vl35hA4DgqoAFqe+MrbqCzZCeutyJK2vwFWzD0XvSDi1k PAo6RO9N9P4zKHpvyetWB+tkH7Yl8ZOVNuSU2WIK5SUCWhBKsv6x6YOIsbXPW+2e Xq+2w7Fj+0XaVW/ckSyhYPG//c5af2FN38o0GCuSulCh93IYzBbWGWueurash3Uo fzkl4/bTbTsjwQ0EXU00bN4FoAxYEXsAZqQ1ssIJ75cUj8qNRdy/Cp8W/KO1VQjG EGrcATeNg4ocvSTiMkkEn/Nx/ziSS0yS+ZiegxjryUOYiHdzcgUdADxG3mmNfxfD /tgtmS/kJcHj6DWbQi0TSsbKL4dNsVdhl7yQhv/OrURgRxjBKMSF34przM/5fG8x cY87NSoLTHPFlhq+BTSTxk33n/K1G+s4oRjAJ3igwWhPzsHsABxkfJYwVHymm5ow mpGv7NB6gYAzoLgw2+vLCNadOlpkXis4MSq4zMovVeBde2lg7Zhd/epPbFyNHvCM 76WSycwdil1kPLf613p2QrP2JkzSrW2iiOgH461iq4SsddVTkOOWL8gE1h7lxgdX 9yndbpxUkUq3uJ9PRMxUTYbTMK++idex4kC3nQ028wbahtdCSJ8= =V6Mv -----END PGP SIGNATURE----- --gtr253shthtd5mif--