mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Seraphime Kirkovski <kirkseraph@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: sfr@canb.auug.org.au, Seraphime Kirkovski <kirkseraph@gmail.com>,
	Jens Axboe <axboe@fb.com>, Ming Lei <tom.leiming@gmail.com>,
	Hannes Reinecke <hare@suse.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Omar Sandoval <osandov@fb.com>
Subject: [PATCH] drivers: block: correct brackets
Date: Fri,  9 Jun 2017 14:07:06 +0200	[thread overview]
Message-ID: <20170609120707.323-1-kirkseraph@gmail.com> (raw)

GCC complained on linux-next about

drivers/block/loop.c:1149:3: warning: this ‘if’ clause does not guard...
[-Wmisleading-indentation]
   if (figure_loop_size(lo, info->lo_offset, info->lo_sizelimit,
   ^~
drivers/block/loop.c:1152:4: note: ...this statement, but the latter is
misleadingly indented as if it is guarded by the ‘if’
    goto exit;

This adjustes the brackets to the inner if.

Fixes: f2c6df7dbf9a ("loop: support 4k physical blocksize")
Signed-off-by: Seraphime Kirkovski <kirkseraph@gmail.com>
---
 The patch was made against linux-next.

 drivers/block/loop.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index 4d376c10a97a..e288fb30100f 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -1147,10 +1147,11 @@ loop_set_status(struct loop_device *lo, const struct loop_info64 *info)
 	    ((lo->lo_flags & LO_FLAGS_BLOCKSIZE) &&
 	     lo->lo_logical_blocksize != LO_INFO_BLOCKSIZE(info))) {
 		if (figure_loop_size(lo, info->lo_offset, info->lo_sizelimit,
-				     LO_INFO_BLOCKSIZE(info)))
+				     LO_INFO_BLOCKSIZE(info))) {
 			err = -EFBIG;
 			goto exit;
 		}
+	}
 
 	loop_config_discard(lo);
 
-- 
2.11.0

                 reply	other threads:[~2017-06-09 12:07 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170609120707.323-1-kirkseraph@gmail.com \
    --to=kirkseraph@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@fb.com \
    --cc=hare@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=osandov@fb.com \
    --cc=sfr@canb.auug.org.au \
    --cc=tom.leiming@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®