From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751747AbdFIPyb (ORCPT ); Fri, 9 Jun 2017 11:54:31 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:44209 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751534AbdFIPya (ORCPT ); Fri, 9 Jun 2017 11:54:30 -0400 From: Colin King To: Jens Axboe , Ming Lei , Hannes Reinecke , Omar Sandoval , Andrew Morton Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH][-next] loop: fix incorrect nesting levels on braces in nested if statements Date: Fri, 9 Jun 2017 16:54:25 +0100 Message-Id: <20170609155425.21260-1-colin.king@canonical.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King Adding another set of braces clarifies the block and ensures that both the setting of err and the error exit are executed on the deepest nested if statement. Detected by CoverityScan, CID#1440959 ("Nesting level does not match indentation") Fixes: f2c6df7dbf9a60 ("loop: support 4k physical blocksize") Signed-off-by: Colin Ian King --- drivers/block/loop.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/block/loop.c b/drivers/block/loop.c index 4d376c10a97a..e288fb30100f 100644 --- a/drivers/block/loop.c +++ b/drivers/block/loop.c @@ -1147,10 +1147,11 @@ loop_set_status(struct loop_device *lo, const struct loop_info64 *info) ((lo->lo_flags & LO_FLAGS_BLOCKSIZE) && lo->lo_logical_blocksize != LO_INFO_BLOCKSIZE(info))) { if (figure_loop_size(lo, info->lo_offset, info->lo_sizelimit, - LO_INFO_BLOCKSIZE(info))) + LO_INFO_BLOCKSIZE(info))) { err = -EFBIG; goto exit; } + } loop_config_discard(lo); -- 2.11.0