From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751763AbdFIQrf (ORCPT ); Fri, 9 Jun 2017 12:47:35 -0400 Received: from mga01.intel.com ([192.55.52.88]:28259 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751675AbdFIQre (ORCPT ); Fri, 9 Jun 2017 12:47:34 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,317,1493708400"; d="scan'208";a="111254634" Date: Fri, 9 Jun 2017 09:47:33 -0700 From: Andi Kleen To: Peter Zijlstra Cc: Stephane Eranian , Andi Kleen , Arnaldo Carvalho de Melo , LKML , Jiri Olsa , Sukadev Bhattiprolu , Madhavan Srinivasan Subject: Re: [PATCH v2 2/4] perf/x86: Fix data source decoding for Skylake Message-ID: <20170609164733.GB28361@tassilo.jf.intel.com> References: <20170607232226.26365-1-andi@firstfloor.org> <20170607232226.26365-3-andi@firstfloor.org> <20170608081531.iv27xaghntniwmm6@hirez.programming.kicks-ass.net> <20170608200302.GC8337@worktop.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170608200302.GC8337@worktop.programming.kicks-ass.net> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > > So one thing we could do is add a mem_hops field and always set that, > > > even for the old stuff. The old stuff will not know about that field and > > > ignore the bits, but new stuff will then not need as many LVL bits. > > > > > That would be better than lvlx I think. I am guessing you're suggesting > > an integer count here and not a bitmask. Right? > > Yah, 0 hops = local, etc.. This doesn't work on Skylake because it doesn't report the number of hops, just remote or not. Would need a wildcard entry, but that can as well be a separate bit. That's what I did in the latest version of my patch. -Andi