From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751806AbdFJW6O (ORCPT ); Sat, 10 Jun 2017 18:58:14 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:37550 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751633AbdFJW6N (ORCPT ); Sat, 10 Jun 2017 18:58:13 -0400 Date: Sat, 10 Jun 2017 18:58:11 -0400 (EDT) Message-Id: <20170610.185811.1771245027556677313.davem@davemloft.net> To: colona@arista.com Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] tcp: md5: extend the tcp_md5sig struct to specify a key address prefix From: David Miller In-Reply-To: <20170610021449.16091-2-colona@arista.com> References: <20170607005414.25361-1-colona@arista.com> <20170610021449.16091-1-colona@arista.com> <20170610021449.16091-2-colona@arista.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 10 Jun 2017 15:16:32 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ivan Delalande Date: Fri, 9 Jun 2017 19:14:49 -0700 > Add a flag field and address prefix length at the end of the tcp_md5sig > structure so users can configure an address prefix length along with a > key. Make sure shorter option values are still accepted in > tcp_v4_parse_md5_keys and tcp_v6_parse_md5_keys to maintain backward > compatibility. > > Signed-off-by: Bob Gilligan > Signed-off-by: Eric Mowat > Signed-off-by: Ivan Delalande As I believe was previously stated, the problem with this approach is that if a new tool requests the prefix length and is run on an older kernel, the kernel will return success even though the prefix length was not taken into account. We do not want to get a success back when the operation requested was not performed.