mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Derek Robson <robsonde@gmail.com>
To: casey@schaufler-ca.com, james.l.morris@oracle.com, serge@hallyn.com
Cc: linux-security-module@vger.kernel.org,
	linux-kernel@vger.kernel.org, Derek Robson <robsonde@gmail.com>
Subject: [PATCH] security: smack: smack.h - style fix
Date: Sat, 10 Jun 2017 12:28:55 +1200	[thread overview]
Message-ID: <20170610002855.23473-1-robsonde@gmail.com> (raw)

Fixed checkpatch.pl warnings of "function definition argument FOO should
 also have an identifier name"
Found using checkpatch

Signed-off-by: Derek Robson <robsonde@gmail.com>
---
 security/smack/smack.h | 23 +++++++++++++----------
 1 file changed, 13 insertions(+), 10 deletions(-)

diff --git a/security/smack/smack.h b/security/smack/smack.h
index 612b810fbbc6..f6563c2205b0 100644
--- a/security/smack/smack.h
+++ b/security/smack/smack.h
@@ -308,18 +308,21 @@ struct smk_audit_info {
 /*
  * These functions are in smack_access.c
  */
-int smk_access_entry(char *, char *, struct list_head *);
-int smk_access(struct smack_known *, struct smack_known *,
-	       int, struct smk_audit_info *);
-int smk_tskacc(struct task_smack *, struct smack_known *,
-	       u32, struct smk_audit_info *);
-int smk_curacc(struct smack_known *, u32, struct smk_audit_info *);
-struct smack_known *smack_from_secid(const u32);
+int smk_access_entry(char *subject_label, char *object_label,
+		     struct list_head *rule_list);
+int smk_access(struct smack_known *subject, struct smack_known *object,
+		int request, struct smk_audit_info *a);
+int smk_tskacc(struct task_smack *tsp, struct smack_known *obj_known,
+		u32 mode, struct smk_audit_info *a);
+int smk_curacc(struct smack_known *obj_known,
+		u32 mode, struct smk_audit_info *a);
+struct smack_known *smack_from_secid(const u32 secid);
 char *smk_parse_smack(const char *string, int len);
-int smk_netlbl_mls(int, char *, struct netlbl_lsm_secattr *, int);
-struct smack_known *smk_import_entry(const char *, int);
+int smk_netlbl_mls(int level, char *catset,
+		   struct netlbl_lsm_secattr *sap, int len);
+struct smack_known *smk_import_entry(const char *string, int len);
 void smk_insert_entry(struct smack_known *skp);
-struct smack_known *smk_find_entry(const char *);
+struct smack_known *smk_find_entry(const char *string);
 int smack_privileged(int cap);
 void smk_destroy_label_list(struct list_head *list);
 
-- 
2.13.0

             reply	other threads:[~2017-06-10  0:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-10  0:28 Derek Robson [this message]
2017-06-13 18:10 ` Casey Schaufler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170610002855.23473-1-robsonde@gmail.com \
    --to=robsonde@gmail.com \
    --cc=casey@schaufler-ca.com \
    --cc=james.l.morris@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=serge@hallyn.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®